Skip to content

test(linter): enable more no-misleading-character-class tests#19005

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-05-test_linter_enable_more_no-misleading-character-class_tests
Feb 6, 2026
Merged

test(linter): enable more no-misleading-character-class tests#19005
graphite-app[bot] merged 1 commit intomainfrom
02-05-test_linter_enable_more_no-misleading-character-class_tests

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Feb 5, 2026 •
edited
Loading

after #18998 the tests are now passing now

@github-actions github-actions bot added the A-linter Area - Linter label Feb 5, 2026
@Sysix Graphite App
Copy link
Member Author

Sysix commented Feb 5, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Feb 5, 2026
This was referenced Feb 5, 2026
Merged
Merged
@Sysix Sysix marked this pull request as ready for review February 5, 2026 17:48
@Sysix Sysix requested a review from camc314 as a code owner February 5, 2026 17:48
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2026

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing 02-05-test_linter_enable_more_no-misleading-character-class_tests (7d6eaf6) with fix/regexp-unicode-escape-kind (81e896f)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on fix/regexp-unicode-escape-kind (66881ba) during the generation of this report, so bcc9ada was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@graphite-app graphite-app bot changed the base branch from fix/regexp-unicode-escape-kind to graphite-base/19005 February 6, 2026 00:37
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 6, 2026
@Boshen Boshen force-pushed the graphite-base/19005 branch from 66881ba to b249ee2 Compare February 6, 2026 02:35
@Boshen Boshen force-pushed the 02-05-test_linter_enable_more_no-misleading-character-class_tests branch from 7d6eaf6 to 97c1de0 Compare February 6, 2026 02:35
@graphite-app graphite-app bot changed the base branch from graphite-base/19005 to main February 6, 2026 02:36
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 6, 2026 •
edited
Loading

Merge activity

  • Feb 6, 2:36 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Feb 6, 11:57 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Feb 6, 12:07 PM UTC: Merged by the Graphite merge queue.

Copilot AI review requested due to automatic review settings February 6, 2026 11:52
@Sysix Sysix force-pushed the 02-05-test_linter_enable_more_no-misleading-character-class_tests branch from 97c1de0 to 87f78a7 Compare February 6, 2026 11:52
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables 4 previously commented-out test cases for the no-misleading-character-class ESLint rule. These tests now pass after PR #18998 fixed the handling of unicode escape sequences in regex patterns created from string literals. The fix ensures that unicode escapes like \uXXXX are correctly identified as CharacterKind::UnicodeEscape rather than CharacterKind::Symbol.

Changes:

  • Removed resolved issue #13660 from TODO comment since it was fixed by PR #18998
  • Enabled 3 test cases using RegExp() with string literals containing unicode escape sequences
  • Enabled 1 test case using RegExp() with template literal containing unicode escape sequences

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app bot pushed a commit that referenced this pull request Feb 6, 2026
@Sysix
test(linter): enable more no-misleading-character-class tests (#19005)
a308b42 
after #18998 the tests are now passing now
@graphite-app graphite-app bot force-pushed the 02-05-test_linter_enable_more_no-misleading-character-class_tests branch from 87f78a7 to a308b42 Compare February 6, 2026 11:57
@graphite-app graphite-app bot force-pushed the 02-05-test_linter_enable_more_no-misleading-character-class_tests branch from a308b42 to f0df9ed Compare February 6, 2026 12:01
@graphite-app graphite-app bot merged commit f0df9ed into main Feb 6, 2026
21 checks passed
@graphite-app graphite-app bot deleted the 02-05-test_linter_enable_more_no-misleading-character-class_tests branch February 6, 2026 12:07
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 6, 2026
OskarLebuda pushed a commit to OskarLebuda/oxc that referenced this pull request Feb 17, 2026
@Sysix @OskarLebuda
test(linter): enable more no-misleading-character-class tests (oxc-…
103b746 
…project#19005)

after oxc-project#18998 the tests are now passing now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sysix @camc314

Comments