fix(linter): Fix the behavior of `import/extensions` rule for a file that has multiple extensions. by connorshea · Pull Request #18919 · oxc-project/oxc

connorshea · 2026-02-04T05:05:50Z

See #18918 for details and a test repo. This fixes the problematic behavior of the Oxlint implementation so we match the implementation from the original import plugin.

Basically, we want to have tsx: never in the rule config, and in that case it should disallow this:

import Foo from "./Foo.stories.tsx";

It correctly did that, but if you removed the tsx extension, you would end up with an error about not allowing the stories extension, which was nonsensical. Now we correctly handle this behavior, so import Foo from "./Foo.stories"; is allowed for this config setting.

Built with Claude Code, reviewed and tested by me. Another user also confirmed that this fixes the problem for them.

Fixes #18918 and #18681.

crates/oxc_linter/src/rules/import/extensions.rs

Copilot

Pull request overview

This PR fixes the import/extensions rule to correctly handle files with multiple extensions (e.g., Component.stories.tsx). Previously, when configured with tsx: never, importing ./Component.stories (without the tsx extension) would incorrectly flag the stories extension. The fix ensures that only the actual file extension is checked, not intermediate extensions in multi-part filenames.

Changes:

Modified extension detection logic to compare the written extension against the resolved file extension
Added test cases for files with multiple extensions (.stories.tsx, .test.ts, .spec.js)
Created fixture files to enable proper module resolution testing

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/oxc_linter/src/rules/import/extensions.rs`	Updated `validate_extension` method to correctly determine if an extension is written by comparing written vs resolved extensions; added test cases for multi-extension files
`crates/oxc_linter/src/snapshots/import_extensions.snap`	Added expected error output for new test cases
`crates/oxc_linter/fixtures/import/Component.stories.tsx`	Fixture file for testing multi-extension imports with tsx
`crates/oxc_linter/fixtures/import/utils.test.ts`	Fixture file for testing multi-extension imports with ts
`crates/oxc_linter/fixtures/import/helper.spec.js`	Fixture file for testing multi-extension imports with js

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codspeed-hq · 2026-02-04T05:11:28Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing extensions-fix (afb8c1c) with main (31b562f)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

connorshea · 2026-02-13T23:17:07Z

@camc314 sorry for the ping 🙇 this is one of the last remaining notable diffs with ESLint for my codebase, if you have time to review it

camc314 · 2026-02-13T23:32:31Z

Apologies for the delay 🙏

camc314 · 2026-02-13T23:32:41Z

Merge activity

Feb 13, 11:32 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 13, 11:32 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 13, 11:38 PM UTC: Merged by the Graphite merge queue.

…that has multiple extensions. (#18919) See #18918 for details and a test repo. This fixes the problematic behavior of the Oxlint implementation so we match the implementation from the original import plugin. Basically, we want to have `tsx: never` in the rule config, and in that case it should disallow this: ```tsx import Foo from "./Foo.stories.tsx"; ``` It correctly did that, but if you _removed_ the `tsx` extension, you would end up with an error about not allowing the `stories` extension, which was nonsensical. Now we correctly handle this behavior, so `import Foo from "./Foo.stories";` is allowed for this config setting. Built with Claude Code, reviewed and tested by me. [Another user also confirmed that this fixes the problem for them](#18681 (comment)). Fixes #18918 and #18681.

connorshea · 2026-02-14T00:22:39Z

Thank you!

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

…that has multiple extensions. (oxc-project#18919) See oxc-project#18918 for details and a test repo. This fixes the problematic behavior of the Oxlint implementation so we match the implementation from the original import plugin. Basically, we want to have `tsx: never` in the rule config, and in that case it should disallow this: ```tsx import Foo from "./Foo.stories.tsx"; ``` It correctly did that, but if you _removed_ the `tsx` extension, you would end up with an error about not allowing the `stories` extension, which was nonsensical. Now we correctly handle this behavior, so `import Foo from "./Foo.stories";` is allowed for this config setting. Built with Claude Code, reviewed and tested by me. [Another user also confirmed that this fixes the problem for them](oxc-project#18681 (comment)). Fixes oxc-project#18918 and oxc-project#18681.

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (oxc-project#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (oxc-project#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (oxc-project#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (oxc-project#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (oxc-project#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (oxc-project#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (oxc-project#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (oxc-project#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (oxc-project#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (oxc-project#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (oxc-project#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (oxc-project#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (oxc-project#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (oxc-project#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (oxc-project#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (oxc-project#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (oxc-project#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (oxc-project#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (oxc-project#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (oxc-project#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (oxc-project#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (oxc-project#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (oxc-project#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (oxc-project#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (oxc-project#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (oxc-project#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (oxc-project#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (oxc-project#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (oxc-project#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (oxc-project#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (oxc-project#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (oxc-project#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (oxc-project#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (oxc-project#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (oxc-project#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (oxc-project#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (oxc-project#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (oxc-project#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (oxc-project#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (oxc-project#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red)

Copilot AI review requested due to automatic review settings February 4, 2026 05:05

connorshea requested a review from camc314 as a code owner February 4, 2026 05:05

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 4, 2026

Copilot started reviewing on behalf of connorshea February 4, 2026 05:06 View session

connorshea commented Feb 4, 2026

View reviewed changes

crates/oxc_linter/src/rules/import/extensions.rs Show resolved Hide resolved

Copilot AI reviewed Feb 4, 2026

View reviewed changes

connorshea mentioned this pull request Feb 4, 2026

linter: import/extensions inconsistency between Oxlint and ESLint for resolvable import path with dot #18681

Closed

connorshea force-pushed the extensions-fix branch from d5346d8 to d4e7bf0 Compare February 10, 2026 01:08

connorshea assigned camc314 Feb 10, 2026

connorshea force-pushed the extensions-fix branch from d4e7bf0 to afb8c1c Compare February 10, 2026 23:28

camc314 approved these changes Feb 13, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 13, 2026

graphite-app bot force-pushed the extensions-fix branch from afb8c1c to 6bc8aec Compare February 13, 2026 23:33

graphite-app bot merged commit 6bc8aec into main Feb 13, 2026
21 checks passed

graphite-app bot deleted the extensions-fix branch February 13, 2026 23:38

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 13, 2026

Boshen mentioned this pull request Feb 16, 2026

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

camc314 mentioned this pull request Feb 16, 2026

linter: import/extensions false positive #19431

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): Fix the behavior of `import/extensions` rule for a file that has multiple extensions.#18919

fix(linter): Fix the behavior of `import/extensions` rule for a file that has multiple extensions.#18919
graphite-app[bot] merged 1 commit intomainfrom
extensions-fix

connorshea commented Feb 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

connorshea commented Feb 13, 2026

Uh oh!

camc314 commented Feb 13, 2026

Uh oh!

camc314 commented Feb 13, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

connorshea commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

connorshea commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codspeed-hq bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

connorshea commented Feb 13, 2026

Uh oh!

camc314 commented Feb 13, 2026

Uh oh!

camc314 commented Feb 13, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

connorshea commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

connorshea commented Feb 4, 2026 •

edited

Loading

codspeed-hq bot commented Feb 4, 2026 •

edited

Loading

camc314 commented Feb 13, 2026 •

edited by graphite-app bot

Loading