fix(parser): validate TypeScript import type options by Boshen · Pull Request #18889 · oxc-project/oxc

Boshen · 2026-02-03T12:55:31Z

Summary

Add validation for TypeScript import type options (typeof import("...", { with: {...} }))
Require with or assert keyword as identifier (not string, not escaped)
Reject computed property keys in attributes object
Reject spread elements in attributes object

This fixes 4 Babel conformance tests:

invalid-import-type-options-escaped-with
invalid-import-type-options-string-with
invalid-import-type-options-with-computed-properties
invalid-import-type-options-with-spread-element

parser_babel Negative Passed: 1655/1689 → 1659/1689 (+4)

🤖 Generated with Claude Code

Copilot

Pull request overview

This pull request adds validation for TypeScript import type options to ensure proper syntax compliance with the import attributes/assertions specification. The changes enforce that import type options must use either with or assert as an identifier keyword, and reject invalid patterns like escaped keywords, string literals as keywords, computed properties, or spread elements in the attributes object.

Changes:

Replaced generic parse_object_expression() call with specialized parse_ts_import_type_options() parser
Added parse_ts_import_type_attributes() to parse and validate the attributes object with strict rules
Added three new diagnostic messages for import type options validation errors

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/oxc_parser/src/ts/types.rs	Implements `parse_ts_import_type_options()` and `parse_ts_import_type_attributes()` functions to validate TypeScript import type syntax according to the spec
crates/oxc_parser/src/diagnostics.rs	Adds three new error diagnostics: expected 'with', invalid computed key, and no spread elements
tasks/coverage/snapshots/parser_babel.snap	Updates to show 4 new passing conformance tests for the Babel test suite
tasks/coverage/snapshots/parser_typescript.snap	Updates error messages for TypeScript test cases that use the old non-standard syntax
tasks/coverage/snapshots/parser_misc.snap	Updates error messages for misc test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_parser/src/ts/types.rs

crates/oxc_parser/src/diagnostics.rs

codspeed-hq · 2026-02-03T14:00:59Z

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing fix/parser-ts-import-type-options (4f02eb4) with main (f609cb6)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Boshen · 2026-02-03T14:46:26Z

Merge activity

Feb 3, 2:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 3, 2:46 PM UTC: Boshen added this pull request to the Graphite merge queue.
Feb 3, 2:53 PM UTC: Merged by the Graphite merge queue.

## Summary - Add validation for TypeScript import type options (`typeof import("...", { with: {...} })`) - Require `with` or `assert` keyword as identifier (not string, not escaped) - Reject computed property keys in attributes object - Reject spread elements in attributes object This fixes 4 Babel conformance tests: - `invalid-import-type-options-escaped-with` - `invalid-import-type-options-string-with` - `invalid-import-type-options-with-computed-properties` - `invalid-import-type-options-with-spread-element` **parser_babel Negative Passed**: 1655/1689 → 1659/1689 (+4) 🤖 Generated with [Claude Code](https://claude.ai/code)

### 💥 BREAKING CHANGES - 2bf7293 mangler: [**BREAKING**] Enable `top_level` by default for modules and commonjs (#18278) (sapphi-red) - 48b0542 span: [**BREAKING**] SourceType::ts should set module to unambigious (#18873) (Boshen) ### 🚀 Features - 500d071 minifier: Local traverse ctx and generated minifier traverse (#19106) (Boshen) - 142a1be parser: Detect binary files with TS1490 error (#19047) (Boshen) - e316857 allocator/bitset: Add `Ones` iterator to `BitSet` (#19027) (sapphi-red) - 742ad3f minifier: Default `invalid_import_side_effects` to `false` (#18916) (sapphi-red) - 0eff6be parser: Error JSX-like type assertions and generics in `.mts`/`.cts` (#18910) (Boshen) - 18320c6 span: Store file extension in `SourceType` (#18893) (Boshen) ### 🐛 Bug Fixes - a7514e4 isolated-declarations: Preserve const context in literal type inference (#19178) (camc314) - 312e756 isolated-declarations: Preserve readonly literal initializers (#19177) (camc314) - d0ca8d0 isolated-declarations: Skip parenthesis when inferring type (#19176) (camc314) - 110c300 oxc_ecmascript: `+[false]` and `+[true]` should evaluate to `NaN` (#19174) (copilot-swe-agent) - f32ea19 semantic: Report redeclaration error for import bindings conflicting with value declarations (#19068) (Boshen) - 3aeba7a semantic: Report redeclaration error for `function a() {} var a` in module mode (#19041) (Boshen) - 35e32c6 coverage: Match Babel's options.json inheritance for test fixtures (#19002) (Boshen) - 463d60d semantic: Skip TS2391 for standalone computed-name class methods (#19025) (Boshen) - 56c086b parser: Add modifier ordering validation (TS1029) (#19024) (Boshen) - 6067a49 linter/jsdoc: False positive in `check-tag-names` for `@` in email addresses and npm scopes (#19021) (Boshen) - b13bb70 semantic/jsdoc: Inline tags like `{@link}` break jsdoc parsing (#19019) (Boshen) - e3609e3 regular_expression: Preserve UnicodeEscape CharacterKind in string literals (#18998) (Boshen) - 57917ee parser: Parse decorators on rest parameters (#18938) (Boshen) - 487601b napi: Disable mimalloc on Windows to fix worker_threads crash (#18923) (Boshen) - 1f6b193 parser: Validate TypeScript import type options (#18889) (Boshen) - 1663184 parser: Allow conditional types in function type parameters (#18886) (Boshen) - 5758046 parser: Error on property access after instantiation expression (#18887) (Boshen) - 5eb4a94 parser: Handle `<<` as two `<` tokens in type argument contexts (#18885) (Boshen) ### ⚡ Performance - ed8c054 oxc_str: Add precomputed hash to Ident for fast HashMap lookups (#19143) (Boshen) - d4a0867 transformer_plugins: Switch ReplaceGlobalDefines from Traverse to VisitMut (#19146) (Boshen) - 9eb16b3 syntax: Pack ASCII identifier tables into single bitflag table (#19088) (Boshen) - e7595d1 mangler: Use BitSet for exported symbols set (#19023) (sapphi-red) - 2537924 semantic: Optimize scope resolution with fast paths and inlining (#19029) (Boshen) - 69a8d85 mangler: Use BitSet for keep_names symbols set (#19028) (sapphi-red) - f78c525 parser: Try hybrid parsing for jsx children and closing element/fragments (#18789) (camchenry) Co-authored-by: camc314 <[email protected]>

### 💥 BREAKING CHANGES - 2bf7293 mangler: [**BREAKING**] Enable `top_level` by default for modules and commonjs (oxc-project#18278) (sapphi-red) - 48b0542 span: [**BREAKING**] SourceType::ts should set module to unambigious (oxc-project#18873) (Boshen) ### 🚀 Features - 500d071 minifier: Local traverse ctx and generated minifier traverse (oxc-project#19106) (Boshen) - 142a1be parser: Detect binary files with TS1490 error (oxc-project#19047) (Boshen) - e316857 allocator/bitset: Add `Ones` iterator to `BitSet` (oxc-project#19027) (sapphi-red) - 742ad3f minifier: Default `invalid_import_side_effects` to `false` (oxc-project#18916) (sapphi-red) - 0eff6be parser: Error JSX-like type assertions and generics in `.mts`/`.cts` (oxc-project#18910) (Boshen) - 18320c6 span: Store file extension in `SourceType` (oxc-project#18893) (Boshen) ### 🐛 Bug Fixes - a7514e4 isolated-declarations: Preserve const context in literal type inference (oxc-project#19178) (camc314) - 312e756 isolated-declarations: Preserve readonly literal initializers (oxc-project#19177) (camc314) - d0ca8d0 isolated-declarations: Skip parenthesis when inferring type (oxc-project#19176) (camc314) - 110c300 oxc_ecmascript: `+[false]` and `+[true]` should evaluate to `NaN` (oxc-project#19174) (copilot-swe-agent) - f32ea19 semantic: Report redeclaration error for import bindings conflicting with value declarations (oxc-project#19068) (Boshen) - 3aeba7a semantic: Report redeclaration error for `function a() {} var a` in module mode (oxc-project#19041) (Boshen) - 35e32c6 coverage: Match Babel's options.json inheritance for test fixtures (oxc-project#19002) (Boshen) - 463d60d semantic: Skip TS2391 for standalone computed-name class methods (oxc-project#19025) (Boshen) - 56c086b parser: Add modifier ordering validation (TS1029) (oxc-project#19024) (Boshen) - 6067a49 linter/jsdoc: False positive in `check-tag-names` for `@` in email addresses and npm scopes (oxc-project#19021) (Boshen) - b13bb70 semantic/jsdoc: Inline tags like `{@link}` break jsdoc parsing (oxc-project#19019) (Boshen) - e3609e3 regular_expression: Preserve UnicodeEscape CharacterKind in string literals (oxc-project#18998) (Boshen) - 57917ee parser: Parse decorators on rest parameters (oxc-project#18938) (Boshen) - 487601b napi: Disable mimalloc on Windows to fix worker_threads crash (oxc-project#18923) (Boshen) - 1f6b193 parser: Validate TypeScript import type options (oxc-project#18889) (Boshen) - 1663184 parser: Allow conditional types in function type parameters (oxc-project#18886) (Boshen) - 5758046 parser: Error on property access after instantiation expression (oxc-project#18887) (Boshen) - 5eb4a94 parser: Handle `<<` as two `<` tokens in type argument contexts (oxc-project#18885) (Boshen) ### ⚡ Performance - ed8c054 oxc_str: Add precomputed hash to Ident for fast HashMap lookups (oxc-project#19143) (Boshen) - d4a0867 transformer_plugins: Switch ReplaceGlobalDefines from Traverse to VisitMut (oxc-project#19146) (Boshen) - 9eb16b3 syntax: Pack ASCII identifier tables into single bitflag table (oxc-project#19088) (Boshen) - e7595d1 mangler: Use BitSet for exported symbols set (oxc-project#19023) (sapphi-red) - 2537924 semantic: Optimize scope resolution with fast paths and inlining (oxc-project#19029) (Boshen) - 69a8d85 mangler: Use BitSet for keep_names symbols set (oxc-project#19028) (sapphi-red) - f78c525 parser: Try hybrid parsing for jsx children and closing element/fragments (oxc-project#18789) (camchenry) Co-authored-by: camc314 <[email protected]>

Copilot AI review requested due to automatic review settings February 3, 2026 12:55

github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Feb 3, 2026

Copilot started reviewing on behalf of Boshen February 3, 2026 12:55 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

crates/oxc_parser/src/ts/types.rs Show resolved Hide resolved

crates/oxc_parser/src/ts/types.rs Show resolved Hide resolved

crates/oxc_parser/src/ts/types.rs Outdated Show resolved Hide resolved

crates/oxc_parser/src/diagnostics.rs Show resolved Hide resolved

Boshen force-pushed the fix/parser-ts-import-type-options branch from 9947c4d to 089d238 Compare February 3, 2026 13:54

Boshen force-pushed the fix/parser-ts-import-type-options branch from 089d238 to 4f02eb4 Compare February 3, 2026 14:34

Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 3, 2026

graphite-app bot force-pushed the fix/parser-ts-import-type-options branch from 4f02eb4 to 1f6b193 Compare February 3, 2026 14:47

graphite-app bot merged commit 1f6b193 into main Feb 3, 2026
22 checks passed

graphite-app bot deleted the fix/parser-ts-import-type-options branch February 3, 2026 14:53

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 3, 2026

This was referenced Feb 9, 2026

release(crates): oxc v0.113.0 #19167

Closed

release(crates): oxc v0.113.0 #19210

Merged

Boshen mentioned this pull request Feb 10, 2026

release(crates): oxc v0.113.0 #19215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(parser): validate TypeScript import type options#18889

fix(parser): validate TypeScript import type options#18889
graphite-app[bot] merged 1 commit intomainfrom
fix/parser-ts-import-type-options

Boshen commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

Boshen commented Feb 3, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Uh oh!

Conversation

Boshen commented Feb 3, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Boshen commented Feb 3, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

codspeed-hq bot commented Feb 3, 2026 •

edited

Loading

Boshen commented Feb 3, 2026 •

edited by graphite-app bot

Loading