Skip to content

refactor(linter): extract shared config setting logic#18856

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-02-refactor_linter_extract_shared_config_setting_logic
Feb 2, 2026
Merged

refactor(linter): extract shared config setting logic#18856
graphite-app[bot] merged 1 commit intomainfrom
c/02-02-refactor_linter_extract_shared_config_setting_logic

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 2, 2026

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 2, 2026
@camc314 camc314 mentioned this pull request Feb 2, 2026
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Feb 2, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Feb 2, 2026
Merged
@camc314 camc314 marked this pull request as ready for review February 2, 2026 14:34
Copilot AI review requested due to automatic review settings February 2, 2026 14:34
Copilot AI reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors linter configuration handling by extracting the repeated “set external plugin config directory” logic into a shared helper on Oxlintrc, and updates callers to use it.

Changes:

  • Extracted Oxlintrc::set_config_dir to centralize external plugin config_dir assignment for base config and overrides.
  • Updated Oxlintrc::from_file to use the extracted helper.
  • Updated JS config parsing to compute config_dir and call set_config_dir instead of duplicating the mapping logic.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
crates/oxc_linter/src/config/oxlintrc.rs Adds set_config_dir helper and uses it during config loading to standardize external plugin config_dir propagation.
apps/oxlint/src/js_config.rs Replaces duplicated external plugin config_dir assignment with a call to Oxlintrc::set_config_dir.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 2, 2026 •
edited
Loading

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 2, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing c/02-02-refactor_linter_extract_shared_config_setting_logic (1e4f683) with main (10a3291)1

Summary

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks2

Footnotes

  1. No successful run was found on main (1e4f683) during the generation of this report, so 10a3291 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot force-pushed the c/02-02-test_linter_dynamic-config_test_case_for_jsplugins_in_overrides branch from dab21a8 to b98a11a Compare February 2, 2026 14:41
graphite-app bot pushed a commit that referenced this pull request Feb 2, 2026
@camc314
refactor(linter): extract shared config setting logic (#18856)
ff97e1c
@graphite-app graphite-app bot force-pushed the c/02-02-refactor_linter_extract_shared_config_setting_logic branch from 1b46e68 to ff97e1c Compare February 2, 2026 14:41
@camc314 camc314 marked this pull request as draft February 2, 2026 14:45
Base automatically changed from c/02-02-test_linter_dynamic-config_test_case_for_jsplugins_in_overrides to main February 2, 2026 14:47
@camc314 camc314 force-pushed the c/02-02-refactor_linter_extract_shared_config_setting_logic branch from ff97e1c to c980716 Compare February 2, 2026 14:50
@github-actions github-actions bot added the A-linter-plugins Area - Linter JS plugins label Feb 2, 2026
@camc314 camc314 mentioned this pull request Feb 2, 2026
Merged
@camc314 camc314 marked this pull request as ready for review February 2, 2026 14:50
@camc314 camc314 force-pushed the c/02-02-refactor_linter_extract_shared_config_setting_logic branch from c980716 to 73395a0 Compare February 2, 2026 14:50
@camc314 camc314 self-assigned this Feb 2, 2026
@graphite-app graphite-app bot force-pushed the c/02-02-refactor_linter_extract_shared_config_setting_logic branch from 73395a0 to 1e4f683 Compare February 2, 2026 14:58
@graphite-app graphite-app bot merged commit 1e4f683 into main Feb 2, 2026
30 checks passed
@graphite-app graphite-app bot deleted the c/02-02-refactor_linter_extract_shared_config_setting_logic branch February 2, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314

Comments