refactor(linter/plugins): remove `oxlint/plugins` export by overlookmotel · Pull Request #18829 · oxc-project/oxc

overlookmotel · 2026-02-02T01:17:21Z

Remove the oxlint/plugins export and the plugins.ts entry point. These are now only used in tests, where the files can be loaded from dist-pkg-plugins instead.

We don't want to encourage people to use oxlint/plugins in their plugins - they should be using @oxlint/plugins package instead to avoid their plugin having a dependency on oxlint.

Due to less shared dependencies between files, this results in 5 less files in dist directory in release build.

This also allows re-enabling the debug assertions in this code in tests.

overlookmotel · 2026-02-02T01:17:36Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR removes the oxlint/plugins export from the main oxlint package to encourage users to use the @oxlint/plugins package instead, avoiding unnecessary dependencies. The export is conditionally retained in debug builds for tests and conformance testing.

Changes:

Removed ./plugins export from both npm/oxlint/package.json and apps/oxlint/package.json
Made plugins.ts entry point conditional in build config, only included when DEBUG=true

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
npm/oxlint/package.json	Removed `./plugins` export entry to prevent users from importing from `oxlint/plugins`
apps/oxlint/package.json	Removed `./plugins` export entry from development package
apps/oxlint/tsdown.config.ts	Added conditional inclusion of `plugins.ts` entry point based on DEBUG flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/oxlint/tsdown.config.ts

camc314 · 2026-02-04T09:58:19Z

Merge activity

Feb 4, 9:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 4, 12:42 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 4, 12:52 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test Linux').
Feb 4, 1:12 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 4, 1:16 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Feb 4, 1:16 PM UTC: Merged by the Graphite merge queue.

Continuation of #18824, #18828, #18903. Remove the `oxlint/plugins` export and the `plugins.ts` entry point. These are now only used in tests, where the files can be loaded from `dist-pkg-plugins` instead. We don't want to encourage people to use `oxlint/plugins` in their plugins - they should be using `@oxlint/plugins` package instead to avoid their plugin having a dependency on `oxlint`. Due to less shared dependencies between files, this results in 5 less files in `dist` directory in release build. This also allows re-enabling the debug assertions in this code in tests.

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 2, 2026

overlookmotel mentioned this pull request Feb 2, 2026

feat(linter/plugins): add @oxlint/plugins NPM package #18824

Merged

overlookmotel mentioned this pull request Feb 2, 2026

refactor(linter/plugins): remove deprecated exports from index entry point #18828

Merged

overlookmotel marked this pull request as ready for review February 2, 2026 01:30

overlookmotel requested a review from camc314 as a code owner February 2, 2026 01:30

Copilot AI review requested due to automatic review settings February 2, 2026 01:30

Copilot started reviewing on behalf of overlookmotel February 2, 2026 01:31 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

apps/oxlint/tsdown.config.ts Outdated Show resolved Hide resolved

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_deprecated_exports_from_index_entry_point branch from 750b313 to 0574159 Compare February 2, 2026 01:39

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from 8d0bbb6 to 3d65f2d Compare February 2, 2026 01:39

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_deprecated_exports_from_index_entry_point branch from 0574159 to 5504055 Compare February 2, 2026 02:15

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from 3d65f2d to 0561fa6 Compare February 2, 2026 02:15

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_deprecated_exports_from_index_entry_point branch from 5504055 to 74ad0f7 Compare February 2, 2026 02:18

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from 0561fa6 to d433098 Compare February 2, 2026 02:18

overlookmotel assigned camc314 Feb 2, 2026

Dunqing mentioned this pull request Feb 2, 2026

formatter: difference with prettier on chained method call with function as argument #16177

Closed

camc314 reviewed Feb 2, 2026

View reviewed changes

apps/oxlint/tsdown.config.ts Outdated Show resolved Hide resolved

overlookmotel added the A-linter-plugins Area - Linter JS plugins label Feb 2, 2026

overlookmotel changed the base branch from om/02-02-refactor_linter_plugins_remove_deprecated_exports_from_index_entry_point to graphite-base/18829 February 3, 2026 10:38

overlookmotel force-pushed the graphite-base/18829 branch from 74ad0f7 to 57d8045 Compare February 3, 2026 10:38

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from d433098 to d62f718 Compare February 3, 2026 10:38

overlookmotel changed the base branch from graphite-base/18829 to om/02-02-feat_linter_plugins_add_oxlint_plugins_npm_package February 3, 2026 10:38

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from d62f718 to b5aa5e4 Compare February 3, 2026 14:09

overlookmotel force-pushed the om/02-02-feat_linter_plugins_add_oxlint_plugins_npm_package branch from 57d8045 to 9938dc4 Compare February 3, 2026 14:09

overlookmotel marked this pull request as draft February 3, 2026 14:53

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from b5aa5e4 to 40dbebc Compare February 3, 2026 15:01

graphite-app bot changed the base branch from om/02-02-feat_linter_plugins_add_oxlint_plugins_npm_package to graphite-base/18829 February 3, 2026 15:46

graphite-app bot force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from 40dbebc to c9ce0d1 Compare February 3, 2026 15:55

graphite-app bot changed the base branch from graphite-base/18829 to main February 3, 2026 15:55

graphite-app bot force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from c9ce0d1 to c05bf3e Compare February 3, 2026 15:55

overlookmotel changed the base branch from main to graphite-base/18829 February 3, 2026 17:44

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from c05bf3e to 51f9705 Compare February 3, 2026 17:44

overlookmotel changed the base branch from graphite-base/18829 to om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow February 3, 2026 17:44

This was referenced Feb 3, 2026

build(oxlint): simplify building @oxlint/plugins #18902

Merged

build(oxlint): generate npm/oxlint-plugins in release CI workflow #18903

Merged

overlookmotel changed the title ~~refactor(linter/plugins): remove oxlint/plugins export except in debug builds~~ refactor(linter/plugins): remove oxlint/plugins export Feb 3, 2026

overlookmotel marked this pull request as ready for review February 3, 2026 17:55

overlookmotel requested a review from camc314 February 3, 2026 20:26

camc314 approved these changes Feb 4, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026

graphite-app bot changed the base branch from om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow to graphite-base/18829 February 4, 2026 10:34

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from 51f9705 to e6a714c Compare February 4, 2026 12:29

overlookmotel force-pushed the graphite-base/18829 branch from d4a54e0 to 2e128b1 Compare February 4, 2026 12:29

overlookmotel changed the base branch from graphite-base/18829 to om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow February 4, 2026 12:29

overlookmotel force-pushed the om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow branch from 2e128b1 to b25bd74 Compare February 4, 2026 12:32

overlookmotel force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from e6a714c to 15f9d50 Compare February 4, 2026 12:32

graphite-app bot changed the base branch from om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow to graphite-base/18829 February 4, 2026 12:38

graphite-app bot changed the base branch from graphite-base/18829 to main February 4, 2026 12:47

graphite-app bot force-pushed the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch from 15f9d50 to 9cce17e Compare February 4, 2026 12:48

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026

overlookmotel added 0-merge Merge with Graphite Merge Queue labels Feb 4, 2026

graphite-app bot merged commit 9cce17e into main Feb 4, 2026
34 of 35 checks passed

graphite-app bot deleted the om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds branch February 4, 2026 13:16

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(linter/plugins): remove `oxlint/plugins` export#18829

refactor(linter/plugins): remove `oxlint/plugins` export#18829
graphite-app[bot] merged 1 commit intomainfrom
om/02-02-refactor_linter_plugins_remove_oxlint_plugins_export_except_in_debug_builds

overlookmotel commented Feb 2, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Feb 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 4, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

overlookmotel commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 4, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

overlookmotel commented Feb 2, 2026 •

edited

Loading

overlookmotel commented Feb 2, 2026 •

edited

Loading

camc314 commented Feb 4, 2026 •

edited by graphite-app bot

Loading