refactor(linter/plugins): rename oxlint/plugin to oxlint/plugins#18792
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
eslintCompatPlugin function
#18791
There was a problem hiding this comment.
Pull request overview
Renames the linter plugin helper entrypoint from oxlint/plugin to oxlint/plugins as a step toward extracting plugin-author APIs into a dedicated @oxlint/plugins package.
Changes:
- Rename package export/import subpath from
plugin→plugins(including build entrypoints). - Update internal tests, conformance harness, and fixtures to import from
#oxlint/plugins. - Adjust
apps/oxlint/src-js/plugins.tstype re-export path for ESTree types.
Reviewed changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| npm/oxlint/package.json | Renames published subpath export ./plugin → ./plugins. |
| apps/oxlint/tsdown.config.ts | Updates build entry list to emit plugins entry instead of plugin. |
| apps/oxlint/test/rule_tester.test.ts | Updates type import to reference plugins.ts. |
| apps/oxlint/test/fixtures/utf16_offsets/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/unicode_comments/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/tokens/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/sourceCode_token_methods/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/sourceCode_scope_methods/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/sourceCode_late_access/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/sourceCode/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/settings/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/selector/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/scope_manager/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_outside_cwd/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_name_reserved/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_name_missing/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_name_alias_reserved/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_name_alias_invalid/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_name/plugins/no_name.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/plugin_name/plugins/jsdoc.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/parser_services/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/parent/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/overrides_missing_rule/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/overrides/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/options_invalid/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/options/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/nested_config_duplicate/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/nested_config/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/missing_rule/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/message_interpolation/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/message_id_plugin/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/message_id_interpolation/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/message_id_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/load_paths/plugins/plugin6.mts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/load_paths/plugins/plugin5.cts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/load_paths/plugins/plugin4.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_visit_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_visit_cfg_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_fix_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_create_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_createOnce_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_before_hook_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/lint_after_hook_error/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/languageOptions/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/isSpaceBetween/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/globals/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/getNodeByRangeIndex/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/fixes/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/fixable_boolean/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/estree/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/eslintCompat/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/disable_directives/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/diagnostic_loc/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/defineRule/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/definePlugin/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/createOnce/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/context_wrapping/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/context_properties/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/comments/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/cfg/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/bom/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/basic_warn_severity/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/basic_no_errors/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/basic_multiple_rules/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/basic_many_files/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/test/fixtures/basic/plugin.ts | Updates fixture imports to #oxlint/plugins. |
| apps/oxlint/src-js/plugins.ts | Defines the new plugins entrypoint and re-exports plugin-author API/types. |
| apps/oxlint/src-js/index.ts | Updates deprecation guidance to point to oxlint/plugins. |
| apps/oxlint/package.json | Renames internal imports/exports from plugin → plugins. |
| apps/oxlint/conformance/tester.ts | Updates conformance harness import types to #oxlint/plugins. |
| apps/oxlint/conformance/src/rule_tester.ts | Updates conformance RuleTester import types to #oxlint/plugins. |
| apps/oxlint/conformance/src/groups/stylistic.ts | Updates conformance group import types to #oxlint/plugins. |
| apps/oxlint/conformance/src/groups/sonarjs.ts | Updates conformance group import types to #oxlint/plugins. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
95414cb to
0c382c4
Compare
…18792) Part of #18610. Our intent is to move `definePlugin`, `defineRule`, and `eslintCompatPlugin` to a separate package `@oxlint/plugins` (plural to avoid confusion with naming convention for plugins `oxlint-plugin-xxx`). So rename the current entry point which exports these functions from `oxlint/plugin` to `oxlint/plugins` (plural).
0c382c4 to
9de9385
Compare

Part of #18610.
Our intent is to move
definePlugin,defineRule, andeslintCompatPluginto a separate package@oxlint/plugins(plural to avoid confusion with naming convention for pluginsoxlint-plugin-xxx).So rename the current entry point which exports these functions from
oxlint/plugintooxlint/plugins(plural).