Skip to content

fix(linter/plugins): handle error from destroyWorkspace#18763

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_
Jan 31, 2026
Merged

fix(linter/plugins): handle error from destroyWorkspace#18763
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 31, 2026

destroyWorkspace on JS side can throw an error, at least to debug build. Handle any such errors, rather than ignoring them. This will also catch any NAPI errors.

Copy link
Member Author

overlookmotel commented Jan 31, 2026

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 31, 2026

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ (1d98417) with main (6ad4480)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (00b5eb2) during the generation of this report, so 6ad4480 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review January 31, 2026 13:14
Copilot AI review requested due to automatic review settings January 31, 2026 13:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JS plugin workspace teardown path so Rust can observe and handle errors thrown by the JS destroyWorkspace callback (including NAPI-surface errors), instead of silently ignoring them.

Changes:

  • Change ExternalLinterDestroyWorkspaceCb to return Result<(), String> so errors can propagate to Rust callers.
  • Update the LSP server shutdown flow to check the destroy_workspace result and log failures.
  • Wrap destroyWorkspace with call_with_return_value + channel synchronization to capture JS-side throw/NAPI errors.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/oxc_linter/src/external_linter.rs Updates the destroy-workspace callback type to return Result so failures can be surfaced.
apps/oxlint/src/lsp/server_linter.rs Handles and logs errors returned by destroy_workspace during shutdown.
apps/oxlint/src/js_plugins/external_linter.rs Implements a blocking wrapper around destroyWorkspace that captures JS/NAPI errors via call_with_return_value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel force-pushed the om/01-31-fix_linter_plugins_use_non-blocking_mode_when_calling_destroyworkspace_ branch from d5130ab to 12afba4 Compare January 31, 2026 13:49
@overlookmotel overlookmotel force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from 6bf2be9 to 548af61 Compare January 31, 2026 13:49
@overlookmotel overlookmotel force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from 548af61 to a898a2a Compare January 31, 2026 14:13
@overlookmotel overlookmotel force-pushed the om/01-31-fix_linter_plugins_use_non-blocking_mode_when_calling_destroyworkspace_ branch from 12afba4 to dc04d2a Compare January 31, 2026 14:13
@overlookmotel overlookmotel changed the base branch from om/01-31-fix_linter_plugins_use_non-blocking_mode_when_calling_destroyworkspace_ to graphite-base/18763 January 31, 2026 15:15
@camc314 camc314 force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from d3594e2 to eb36fa9 Compare January 31, 2026 16:46
@camc314 camc314 force-pushed the graphite-base/18763 branch from 255d7fc to cc0558e Compare January 31, 2026 16:46
@camc314 camc314 changed the base branch from graphite-base/18763 to om/01-31-fix_linter_plugins_use_non-blocking_mode_when_calling_destroyworkspace_ January 31, 2026 16:46
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Copy link
Contributor

camc314 commented Jan 31, 2026

Merge activity

  • Jan 31, 4:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 5:11 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 31, 5:13 PM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Jan 31, 7:57 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 8:02 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 31, 8:08 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test Linux').
  • Jan 31, 8:15 PM UTC: Sysix added this pull request to the Graphite merge queue.
  • Jan 31, 8:15 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from om/01-31-fix_linter_plugins_use_non-blocking_mode_when_calling_destroyworkspace_ to graphite-base/18763 January 31, 2026 16:52
@graphite-app graphite-app bot force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from eb36fa9 to e85246b Compare January 31, 2026 16:59
@graphite-app graphite-app bot force-pushed the graphite-base/18763 branch from cc0558e to d981978 Compare January 31, 2026 16:59
@graphite-app graphite-app bot changed the base branch from graphite-base/18763 to main January 31, 2026 17:00
@graphite-app graphite-app bot force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from e85246b to 2a752a8 Compare January 31, 2026 17:00
@camc314 camc314 force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from 2a752a8 to 6cebe6f Compare January 31, 2026 17:04
graphite-app bot pushed a commit that referenced this pull request Jan 31, 2026
`destroyWorkspace` on JS side can throw an error, at least to debug build. Handle any such errors, rather than ignoring them. This will also catch any NAPI errors.
@graphite-app graphite-app bot force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from 6cebe6f to 516f796 Compare January 31, 2026 17:11
@camc314 camc314 marked this pull request as draft January 31, 2026 17:11
@camc314
Copy link
Contributor

camc314 commented Jan 31, 2026

this appears to consistently break the vscode CI - needs invesstigating before merging

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
@Sysix
Copy link
Member

Sysix commented Jan 31, 2026

@camc314 I tried to restack the PR. I am not great at it :') after #18779 it should be possible to merge 🤞

@camc314 camc314 force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from 516f796 to 1d98417 Compare January 31, 2026 19:56
@camc314 camc314 marked this pull request as ready for review January 31, 2026 19:56
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
`destroyWorkspace` on JS side can throw an error, at least to debug build. Handle any such errors, rather than ignoring them. This will also catch any NAPI errors.
@graphite-app graphite-app bot force-pushed the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch from 1d98417 to 95df577 Compare January 31, 2026 20:05
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 31, 2026
@graphite-app graphite-app bot merged commit 95df577 into main Jan 31, 2026
37 of 38 checks passed
@graphite-app graphite-app bot deleted the om/01-31-fix_linter_plugins_handle_error_from_destroyworkspace_ branch January 31, 2026 20:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
camc314 added a commit that referenced this pull request Feb 2, 2026
# Oxlint
### 💥 BREAKING CHANGES

- b34a155 linter/plugins: [**BREAKING**] `RuleTester` set
`context.filename` to absolute path (#18702) (overlookmotel)

### 🚀 Features

- 1753209 linter/vscode: Run extension when JS configs are detected
(#18832) (camc314)
- c962dd2 linter/lsp: Implement support for oxlint.config.ts (#18826)
(camc314)
- da32203 linter: Auto generate oxlint.config.ts types (#18597)
(camc314)
- 19b4df7 oxlint: Introduce `defineConfig` helper (#18596) (camc314)
- ea97231 linter: Implement `oxlint.config.ts` support (#17563)
(camc314)
- 17ca42d linter: Implement `react/no-multi-comp` rule. (#18794)
(connorshea)
- 88f30e0 linter/plugins: Move eslint compatible plugin conversion to
`eslintCompatPlugin` function (#18791) (overlookmotel)
- 2a72794 linter/plugins: `RuleTester` take `cwd` property (#18756)
(overlookmotel)
- 9f533db linter: Add `find_prev_token_within` method for token search
(#18769) (camc314)
- 772ea70 linter: Introduce `load_js_configs` napi callback (#18767)
(camc314)
- e9690c1 linter: Introduce `DiscoveredConfig` in preparation for JS
configs (#18674) (camc314)
- 558b588 linter/prefer-namespace-keyword: Move to correctness (#18733)
(camc314)
- 7a5c268 oxlint/lsp: Support `jsPlugins` (#17840) (Sysix)
- c07497c linter/prefer-modern-dom-apis: Implement suggestion (#17965)
(Mikhail Baev)
- 8531bc9 linter: Implement `prefer-const` (#18687) (camchenry)
- 8670b18 parser: Error on ambient class accessor implementations
(#18592) (camc314)
- 6b8a5ae linter: Add `eslint-plugin-import/no-nodejs-modules` rule
(#18006) (Mikhail Baev)
- 04f400d linter/no-duplicates: Add support for `considerQueryString`
option (#18657) (camc314)
- 3b7f260 linter/consistent-generic-constructor: Implement fixer
(#18616) (camc314)
- 794f9e4 linter/prefer-exponentation-operator: Implement suggestion
(#18602) (camc314)
- 773d916 linter: `eslint/sort_keys` ignore leading and trailing spreads
in auto-fix (#18485) (Lonami)
- 20d4ede linter: Implement `import/no-relative-parent-imports` rule
(#18513) (Valentin Maerten)
- 0da45ef vscode: Fallback to globally installed oxlint/oxfmt packages
(#18007) (Sysix)

### 🐛 Bug Fixes

- a3417b1 linter/plugins: Clear state when reloading workspace (#18837)
(overlookmotel)
- c879992 linter: Error on arrays passed in as config (#18822) (camc314)
- 5c80422 linter/tsdown: Ensure relative path for globals import starts
with `./` (#18820) (camc314)
- 7419dfb linter: Remove invalid debug assersion, add test (#18819)
(camc314)
- 0ca6269 ci: Fix the repo path normalization logic for tests on
Windows. (#18815) (connorshea)
- c7b0a65 linter: Fix config option docs for `react/jsx-boolean-value`
rule. (#18811) (connorshea)
- cce374e linter/prefer-const: Replace entire declaration over just the
`let` kw (#18814) (camc314)
- 41f92d1 linter: Error when given config options for a lint rule that
has no config options defined. (#18809) (connorshea)
- 0867a36 linter/consistent-index-object-style: False positive with
mapped + generic types (#18801) (camc314)
- 1d34b42 linter: Fix 32 bit build (#18783) (camc314)
- 95df577 linter/plugins: Handle error from `destroyWorkspace` (#18763)
(overlookmotel)
- b3261dc linter: Fix the curly rule config to enforce the shape of the
config and emit correct docs (#18743) (connorshea)
- d981978 linter/plugins: Use non-blocking mode when calling
`destroyWorkspace` (#18762) (overlookmotel)
- 3f43d4c linter: Accept bools as valid values for `fixable` (#18772)
(camc314)
- 005910a linter/plugins: Support plugins outside of workspace (#18755)
(overlookmotel)
- fd92711 vscode: Use `fsPath` for workspace mapping (#18728) (Sysix)
- 358b2c1 linter/consistent-generic-constructors: Check bounds when
searching for `:` token (#18745) (connorshea)
- abd0c28 linter/capitalized-comments: Fix generated rule option docs
(#18748) (connorshea)
- d90a9f6 linter: Add more tests for `prefer-const`'s fixer and fix its
invalid behavior. (#18747) (connorshea)
- f82011b oxlint/lsp: Disable JS plugins support in LSP except in tests
(#18727) (overlookmotel)
- 94505c8 linter/jest: Change `prefer-spy-on` autofix to suggestion
(#18152) (Ben Lowery)
- 6ec1112 linter: Mark unused disable directive fix as suggestion
(#18703) (ddmoney420)
- 49609ec linter/no-useless-constructor: Consider argument
transformation as used (#18706) (ddmoney420)
- 40218de linter: Fix behavior of
jsx-a11y/no-static-element-interactions rule. (#17817) (connorshea)
- db9751d linter/no-html-link-for-pages: Handle `target=_blank`
correctly (#18693) (camc314)
- e440b78 linter/plugins: Pass all args to CFG event handlers when 2
rules use same handler (#18683) (overlookmotel)
- b393430 linter/curly: Fix multi-or-nest and consistent conflict
(#18660) (camc314)
- 2e1fbc2 linter/plugins: Implement `context.parserPath` (#18644)
(overlookmotel)
- 34951ed linter/plugins: `filename` option takes precedence over
`parserOptions.lang` in `RuleTester` (#18643) (overlookmotel)
- 28df160 linter/plugins: Allow line number passed to `report` to be 0
(#18642) (overlookmotel)
- 14fabec vscode: Use built-in `getWorkspaceFolder` for detecting the
right workspace of a given uri (#18583) (Sysix)
- 0ff4cea oxlint/cli: Report error when nested config could not be
parsed (#18504) (Sysix)

### ⚡ Performance

- 9862224 linter/plugins: Reduce cost of workspaces (#18758)
(overlookmotel)
- 6bc0bde linter: Remove string allocation (#18725) (overlookmotel)
- 3a6b41e linter/plugins: Replace ESLint Traverser with lightweight
traverseNode (#18529) (Rintaro Itokawa)

### 📚 Documentation

- dd1a653 linter: Fix doc comment for ignoreStateless config option.
(#18808) (connorshea)
- 5909085 linter/plugins: Add doc comments (#18753) (overlookmotel)
- ffe53a3 linter: Update lint function docs (#18766) (camc314)
- b82faec linter: Glob for any css module for no-unassigned-import
(#18713) (Ben Stickley)
- cd86347 linter: Mark some react rules as unsupported, misc docs
improvements (#18617) (connorshea)
- 23401d8 linter: Update fixes and suggestions status for tsgolint rules
(#18619) (camchenry)
# Oxfmt
### 🚀 Features

- ee30de9 oxfmt: Add config migration from biome (#18638) (Luca Fischer)

### 🐛 Bug Fixes

- e754b18 oxfmt/migrate-prettier: Set `experimentalSortPackagejson:
false` by default (#18831) (leaysgur)
- a83c266 formatter: Keep decorated function pattern hugged when params
break (#18830) (Dunqing)
- 0c8efe1 formatter: Quote numeric property keys with `quoteProps:
consistent` (#18803) (Dunqing)
- 9c14c3e formatter: Ignore comment does not work for sequence
expressions in arrow function body (#18799) (Dunqing)
- 54984ae formatter: Handle leading comments in arrow function sequence
expressions (#18798) (Dunqing)
- 61bb2b5 formatter: Correctly expand JSX returned from arrow callbacks
in JSX expression containers (#18797) (Dunqing)
- 34ee194 formatter: Tailwindcss sorting doesn't work for object
property keys (#18773) (Dunqing)
- 48f1e35 oxfmt: Prevent ThreadsafeFunction crash on Node.js exit
(#18723) (Boshen)
- e96adca formatter: Follow Prettier's approach for for-in initializer
parentheses (#18695) (Dunqing)
- 1215a6f formatter: Preserve quote for class property key in TypeScript
(#18692) (Dunqing)
- 059acae formatter: Incorrect comments placement for union type in
`TSTypeIntersection` (#18690) (Dunqing)
- c3d05c1 formatter,oxfmt: Handle CRLF with embedded formatting (#18686)
(leaysgur)
- 7cb3085 formatter: Preserve comments on rest elements (#18649)
(Dunqing)
- 21984dd formatter: Preserve type cast comments on rest parameters
(#18648) (Dunqing)
- 2f70254 formatter: Don't add extra semicolon on suppressed class
properties (#18631) (Dunqing)
- ac1ff4e oxfmt: Use `empty_line` IR for empty xxx-in-js line (#18623)
(leaysgur)
- 8f76900 oxfmt: Dedent xxx-in-js templates before calling prettier
(#18622) (leaysgur)
- 6b726ef oxfmt: Trim whitespace only xxx-in-js templates (#18621)
(leaysgur)

Co-authored-by: camc314 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments