Skip to content

refactor(linter/plugins): reorder callback wrapper functions#18760

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions
Jan 31, 2026
Merged

refactor(linter/plugins): reorder callback wrapper functions#18760
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 31, 2026 •
edited
Loading

Pure refactor. Re-order code so create/destroy workspace-related code is last, making order consistent across the codebase.

This was referenced Jan 31, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Jan 31, 2026 •
edited by camc314
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 31, 2026
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 31, 2026
@overlookmotel overlookmotel mentioned this pull request Jan 31, 2026
Merged
@overlookmotel overlookmotel marked this pull request as ready for review January 31, 2026 13:08
Copilot AI review requested due to automatic review settings January 31, 2026 13:08
Copilot AI reviewed Jan 31, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch from a01133c to f313db3 Compare January 31, 2026 13:49
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 29753d5 to 2f20192 Compare January 31, 2026 13:49
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch from f313db3 to c38f130 Compare January 31, 2026 14:13
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 2f20192 to 430606e Compare January 31, 2026 14:13
@overlookmotel overlookmotel mentioned this pull request Jan 31, 2026
Merged
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 430606e to d917477 Compare January 31, 2026 15:15
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch from c38f130 to 9b8cf57 Compare January 31, 2026 15:15
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
@camc314 Graphite App
Copy link
Contributor

camc314 commented Jan 31, 2026 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 31, 2026
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch from 9b8cf57 to 82d5d37 Compare January 31, 2026 15:35
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from d917477 to 430606e Compare January 31, 2026 15:35
@graphite-app graphite-app bot changed the base branch from om/01-31-refactor_linter_plugins_move_imports_to_top_level to graphite-base/18760 January 31, 2026 15:42
@camc314 camc314 force-pushed the graphite-base/18760 branch from 430606e to 91ae2f0 Compare January 31, 2026 16:22
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch from 82d5d37 to 1cda019 Compare January 31, 2026 16:22
@camc314 camc314 changed the base branch from graphite-base/18760 to om/01-31-refactor_linter_plugins_move_imports_to_top_level January 31, 2026 16:22
@overlookmotel
refactor(linter/plugins): reorder callback wrapper functions (#18760)
64ddbe1 
Pure refactor. Re-order code so create/destroy workspace-related code is last, making order consistent across the codebase.
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 91ae2f0 to 6b14dec Compare January 31, 2026 16:34
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch from 1cda019 to 64ddbe1 Compare January 31, 2026 16:34
Base automatically changed from om/01-31-refactor_linter_plugins_move_imports_to_top_level to main January 31, 2026 16:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
@graphite-app graphite-app bot merged commit 64ddbe1 into main Jan 31, 2026
20 checks passed
@graphite-app graphite-app bot deleted the om/01-31-refactor_linter_plugins_reorder_callback_wrapper_functions branch January 31, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314

Comments