Skip to content

refactor(linter/plugins): move imports to top level#18759

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-refactor_linter_plugins_move_imports_to_top_level
Jan 31, 2026
Merged

refactor(linter/plugins): move imports to top level#18759
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-refactor_linter_plugins_move_imports_to_top_level

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 31, 2026 •
edited
Loading

Pure refactor. Just import types at top-level instead if inline. This is consistent with the style of the rest of this file.

This was referenced Jan 31, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Jan 31, 2026 •
edited by camc314
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Jan 31, 2026
Merged
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 31, 2026
This was referenced Jan 31, 2026
Merged
Merged
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review January 31, 2026 13:07
Copilot AI review requested due to automatic review settings January 31, 2026 13:07
Copilot AI reviewed Jan 31, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the import statements in external_linter.rs by moving type imports from inline usage to the top-level import block, making them consistent with the existing code style in the file and across the codebase.

Changes:

  • Added ExternalLinterCreateWorkspaceCb and ExternalLinterDestroyWorkspaceCb to the top-level oxc_linter import block
  • Replaced inline qualified paths (oxc_linter::ExternalLinterCreateWorkspaceCb and oxc_linter::ExternalLinterDestroyWorkspaceCb) with unqualified type names in function signatures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel changed the base branch from om/01-31-perf_linter_plugins_reduce_cost_of_workspaces to graphite-base/18759 January 31, 2026 13:49
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 29753d5 to 2f20192 Compare January 31, 2026 13:49
@overlookmotel overlookmotel changed the base branch from graphite-base/18759 to om/01-31-perf_linter_plugins_reduce_cost_of_workspaces January 31, 2026 13:49
@overlookmotel overlookmotel force-pushed the om/01-31-perf_linter_plugins_reduce_cost_of_workspaces branch from 7778e54 to cd7ed7a Compare January 31, 2026 14:13
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 2f20192 to 430606e Compare January 31, 2026 14:13
@overlookmotel overlookmotel mentioned this pull request Jan 31, 2026
Merged
@overlookmotel overlookmotel changed the base branch from om/01-31-perf_linter_plugins_reduce_cost_of_workspaces to graphite-base/18759 January 31, 2026 15:14
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 430606e to d917477 Compare January 31, 2026 15:15
@overlookmotel overlookmotel changed the base branch from graphite-base/18759 to om/01-31-perf_linter_plugins_reduce_cost_of_workspaces January 31, 2026 15:15
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
@camc314 Graphite App
Copy link
Contributor

camc314 commented Jan 31, 2026 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 31, 3:34 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 3:34 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 31, 3:34 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18756.
  • Jan 31, 3:34 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18756.
  • Jan 31, 3:42 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Jan 31, 3:42 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 31, 3:42 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 3:43 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Jan 31, 3:43 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 31, 3:43 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 4:32 PM UTC: graphite-app added this pull request to the Graphite merge queue.
  • Jan 31, 4:40 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 31, 2026
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from d917477 to 430606e Compare January 31, 2026 15:35
@github-actions github-actions bot added the A-linter-plugins Area - Linter JS plugins label Jan 31, 2026
@graphite-app graphite-app bot changed the base branch from om/01-31-perf_linter_plugins_reduce_cost_of_workspaces to graphite-base/18759 January 31, 2026 15:43
@camc314 camc314 force-pushed the graphite-base/18759 branch from a4af0c5 to 9862224 Compare January 31, 2026 16:22
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 430606e to 91ae2f0 Compare January 31, 2026 16:22
@camc314 camc314 changed the base branch from graphite-base/18759 to om/01-31-perf_linter_plugins_reduce_cost_of_workspaces January 31, 2026 16:22
Base automatically changed from om/01-31-perf_linter_plugins_reduce_cost_of_workspaces to main January 31, 2026 16:26
@overlookmotel
refactor(linter/plugins): move imports to top level (#18759)
6b14dec 
Pure refactor. Just import types at top-level instead if inline. This is consistent with the style of the rest of this file.
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch from 91ae2f0 to 6b14dec Compare January 31, 2026 16:34
@graphite-app graphite-app bot merged commit 6b14dec into main Jan 31, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/01-31-refactor_linter_plugins_move_imports_to_top_level branch January 31, 2026 16:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314

Comments