Skip to content

test(linter/plugins): add cwd option to tests#18754

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-test_linter_plugins_add_cwd_option_to_tests
Jan 31, 2026
Merged

test(linter/plugins): add cwd option to tests#18754
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-test_linter_plugins_add_cwd_option_to_tests

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 31, 2026

Add a cwd option to tests which causes test runner to run Oxlint from within a subfolder inside a fixture dir, instead of root of the fixture dir. This is used for the test added in next PR (#18755).

Copy link
Member Author

overlookmotel commented Jan 31, 2026

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Jan 31, 2026
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Jan 31, 2026
@overlookmotel overlookmotel marked this pull request as ready for review January 31, 2026 12:26
Copilot AI review requested due to automatic review settings January 31, 2026 12:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for running fixture-based CLI tests from a subdirectory within a fixture (via a new cwd option), enabling upcoming plugin-resolution coverage (referenced in PR #18755).

Changes:

  • Extend fixture options.json parsing/types to support a nullable cwd option.
  • Apply the fixture-provided cwd when spawning the test command via execa.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot changed the base branch from om/01-31-docs_linter_plugins_add_doc_comments to graphite-base/18754 January 31, 2026 14:42
@camc314 camc314 force-pushed the graphite-base/18754 branch from f618359 to e9fb488 Compare January 31, 2026 14:44
@camc314 camc314 force-pushed the om/01-31-test_linter_plugins_add_cwd_option_to_tests branch from ce78b95 to 0c06484 Compare January 31, 2026 14:44
@camc314 camc314 changed the base branch from graphite-base/18754 to om/01-31-docs_linter_plugins_add_doc_comments January 31, 2026 14:45
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Copy link
Contributor

camc314 commented Jan 31, 2026

Merge activity

@camc314 camc314 changed the base branch from om/01-31-docs_linter_plugins_add_doc_comments to graphite-base/18754 January 31, 2026 14:46
@graphite-app graphite-app bot changed the base branch from graphite-base/18754 to main January 31, 2026 14:55
Add a `cwd` option to tests which causes test runner to run Oxlint from within a subfolder inside a fixture dir, instead of root of the fixture dir. This is used for the test added in next PR (#18755).
@graphite-app graphite-app bot force-pushed the om/01-31-test_linter_plugins_add_cwd_option_to_tests branch from 0c06484 to b002aa5 Compare January 31, 2026 14:56
@graphite-app graphite-app bot merged commit b002aa5 into main Jan 31, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/01-31-test_linter_plugins_add_cwd_option_to_tests branch January 31, 2026 15:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments