Skip to content

test(linter/plugins): update conformance snapshots#18752

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-test_linter_plugins_update_conformance_snapshots
Jan 31, 2026
Merged

test(linter/plugins): update conformance snapshots#18752
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-test_linter_plugins_update_conformance_snapshots

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 31, 2026

Update conformance snapshots. They got out of sync after #17809 (1 broken test, and change to how code is split across files in bundle).

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 31, 2026
Copy link
Member Author

overlookmotel commented Jan 31, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates conformance test snapshots that became outdated after PR #17809, which refactored the NAPI plugin system and changed how code is bundled across files. The updates address one broken test and reflect changes to the bundle structure.

Changes:

  • Updated stack traces in stylistic.md to reflect new bundle file names (lint.js → load.js)
  • Updated sonarjs.md statistics to reflect a newly failing test in the no-implicit-dependencies rule
  • Added detailed failure information for the no-implicit-dependencies (S4328) test case

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/oxlint/conformance/snapshots/stylistic.md Updated stack trace references from apps/oxlint/dist/lint.js to apps/oxlint/dist/load.js to reflect bundle restructuring
apps/oxlint/conformance/snapshots/sonarjs.md Updated test statistics and added failure details for newly broken no-implicit-dependencies (S4328) test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel marked this pull request as draft January 31, 2026 13:26
@overlookmotel overlookmotel marked this pull request as ready for review January 31, 2026 14:33
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Copy link
Contributor

camc314 commented Jan 31, 2026

Merge activity

Update conformance snapshots. They got out of sync after #17809 (1 broken test, and change to how code is split across files in bundle).
@graphite-app graphite-app bot force-pushed the om/01-31-test_linter_plugins_update_conformance_snapshots branch from a09d03f to 7c7a984 Compare January 31, 2026 14:35
@graphite-app graphite-app bot merged commit 7c7a984 into main Jan 31, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/01-31-test_linter_plugins_update_conformance_snapshots branch January 31, 2026 14:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments