feat(linter/prefer-namespace-keyword): move to correctness by camc314 · Pull Request #18733 · oxc-project/oxc

camc314 · 2026-01-30T14:36:28Z

this is going to be a hard parser error in a future release, so lets move this rule to correctness to allow people to take advantage of the fixer and migrate their code

camc314 · 2026-01-30T14:36:46Z

feat(linter/prefer-namespace-keyword): move to correctness #18733 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

camc314 · 2026-01-30T14:40:12Z

Merge activity

Jan 30, 2:40 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 30, 2:59 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jan 30, 3:06 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

This PR elevates the typescript/prefer-namespace-keyword rule from the style category to correctness, and enriches its diagnostics to guide migration away from module for internal declarations, aligning with upcoming TypeScript parser changes. It also updates Rust snapshots and oxlint CLI snapshots to reflect the new diagnostic text and the increased active rule count.

Changes:

Add a more detailed help + note to the prefer_namespace_keyword diagnostic, explaining that module for internal declarations is becoming a hard/parse error in future TypeScript/Oxlint versions and linking to upstream TypeScript issues/PR.
Change the rule declaration for PreferNamespaceKeyword from the style to the correctness category.
Update linter and CLI snapshot files to match the new diagnostic output and the increased rule count from 90 to 91 where this rule is now included.

Reviewed changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_linter/src/snapshots/typescript_prefer_namespace_keyword.snap	Updates the snapshot to match the new help/note text from `prefer_namespace_keyword_diagnostic`.
crates/oxc_linter/src/rules/typescript/prefer_namespace_keyword.rs	Adds detailed help/note to the diagnostic and moves the rule from `style` to `correctness`.
apps/oxlint/src/snapshots/[email protected]	Adjusts the CLI snapshot’s rule count from 90 to 91 to account for `PreferNamespaceKeyword` now being in `correctness`.
apps/oxlint/src/snapshots/[email protected]	Updates the reported rule count from 104 to 105, reflecting the new category placement for the rule.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI summary line to report 91 rules instead of 90.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI summary to show 91 rules in this fixtures run.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI summary to show 91 rules in this extended-config scenario.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI summary rule count to 91 for the dot-folder fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI summary rule count to 91 for cross-module nested config.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI summary rule count to 91 for the `.asdf` fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the invalid Vue fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the empty Vue fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the Vue debugger fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the Svelte debugger fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the JS-as-JSX fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the basic debugger fixture.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the core linter fixtures collection.
apps/oxlint/src/snapshots/[email protected]	Updates the CLI rule count to 91 for the Astro debugger fixture.

Notes for follow-up:

There are still snapshot files under apps/oxlint/src/snapshots/ containing lines like with 90 rules using 1 threads. (e.g. the -W correctness -A no-debugger and some overrides fixtures) that were not updated; once this rule is in correctness, those runs are likely to report 91 rules and their snapshots will need regeneration.
The new diagnostic note text is clear, but you may want to pluralize “a future TypeScript and Oxlint version” to “future TypeScript and Oxlint versions” for slightly better grammar (comment left on the diagnostic helper).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_linter/src/rules/typescript/prefer_namespace_keyword.rs

codspeed-hq · 2026-01-30T14:44:45Z

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/01-30-feat_linter_prefer-namespace-keyword_clarify_hard-error_deprecation_note (b4c8ff8) with main (7a5c268)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (f82011b) during the generation of this report, so 7a5c268 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

this is going to be a hard parser error in a future release, so lets move this rule to correctness to allow people to take advantage of the fixer and migrate their code

# Oxlint ### 💥 BREAKING CHANGES - b34a155 linter/plugins: [**BREAKING**] `RuleTester` set `context.filename` to absolute path (#18702) (overlookmotel) ### 🚀 Features - 1753209 linter/vscode: Run extension when JS configs are detected (#18832) (camc314) - c962dd2 linter/lsp: Implement support for oxlint.config.ts (#18826) (camc314) - da32203 linter: Auto generate oxlint.config.ts types (#18597) (camc314) - 19b4df7 oxlint: Introduce `defineConfig` helper (#18596) (camc314) - ea97231 linter: Implement `oxlint.config.ts` support (#17563) (camc314) - 17ca42d linter: Implement `react/no-multi-comp` rule. (#18794) (connorshea) - 88f30e0 linter/plugins: Move eslint compatible plugin conversion to `eslintCompatPlugin` function (#18791) (overlookmotel) - 2a72794 linter/plugins: `RuleTester` take `cwd` property (#18756) (overlookmotel) - 9f533db linter: Add `find_prev_token_within` method for token search (#18769) (camc314) - 772ea70 linter: Introduce `load_js_configs` napi callback (#18767) (camc314) - e9690c1 linter: Introduce `DiscoveredConfig` in preparation for JS configs (#18674) (camc314) - 558b588 linter/prefer-namespace-keyword: Move to correctness (#18733) (camc314) - 7a5c268 oxlint/lsp: Support `jsPlugins` (#17840) (Sysix) - c07497c linter/prefer-modern-dom-apis: Implement suggestion (#17965) (Mikhail Baev) - 8531bc9 linter: Implement `prefer-const` (#18687) (camchenry) - 8670b18 parser: Error on ambient class accessor implementations (#18592) (camc314) - 6b8a5ae linter: Add `eslint-plugin-import/no-nodejs-modules` rule (#18006) (Mikhail Baev) - 04f400d linter/no-duplicates: Add support for `considerQueryString` option (#18657) (camc314) - 3b7f260 linter/consistent-generic-constructor: Implement fixer (#18616) (camc314) - 794f9e4 linter/prefer-exponentation-operator: Implement suggestion (#18602) (camc314) - 773d916 linter: `eslint/sort_keys` ignore leading and trailing spreads in auto-fix (#18485) (Lonami) - 20d4ede linter: Implement `import/no-relative-parent-imports` rule (#18513) (Valentin Maerten) - 0da45ef vscode: Fallback to globally installed oxlint/oxfmt packages (#18007) (Sysix) ### 🐛 Bug Fixes - a3417b1 linter/plugins: Clear state when reloading workspace (#18837) (overlookmotel) - c879992 linter: Error on arrays passed in as config (#18822) (camc314) - 5c80422 linter/tsdown: Ensure relative path for globals import starts with `./` (#18820) (camc314) - 7419dfb linter: Remove invalid debug assersion, add test (#18819) (camc314) - 0ca6269 ci: Fix the repo path normalization logic for tests on Windows. (#18815) (connorshea) - c7b0a65 linter: Fix config option docs for `react/jsx-boolean-value` rule. (#18811) (connorshea) - cce374e linter/prefer-const: Replace entire declaration over just the `let` kw (#18814) (camc314) - 41f92d1 linter: Error when given config options for a lint rule that has no config options defined. (#18809) (connorshea) - 0867a36 linter/consistent-index-object-style: False positive with mapped + generic types (#18801) (camc314) - 1d34b42 linter: Fix 32 bit build (#18783) (camc314) - 95df577 linter/plugins: Handle error from `destroyWorkspace` (#18763) (overlookmotel) - b3261dc linter: Fix the curly rule config to enforce the shape of the config and emit correct docs (#18743) (connorshea) - d981978 linter/plugins: Use non-blocking mode when calling `destroyWorkspace` (#18762) (overlookmotel) - 3f43d4c linter: Accept bools as valid values for `fixable` (#18772) (camc314) - 005910a linter/plugins: Support plugins outside of workspace (#18755) (overlookmotel) - fd92711 vscode: Use `fsPath` for workspace mapping (#18728) (Sysix) - 358b2c1 linter/consistent-generic-constructors: Check bounds when searching for `:` token (#18745) (connorshea) - abd0c28 linter/capitalized-comments: Fix generated rule option docs (#18748) (connorshea) - d90a9f6 linter: Add more tests for `prefer-const`'s fixer and fix its invalid behavior. (#18747) (connorshea) - f82011b oxlint/lsp: Disable JS plugins support in LSP except in tests (#18727) (overlookmotel) - 94505c8 linter/jest: Change `prefer-spy-on` autofix to suggestion (#18152) (Ben Lowery) - 6ec1112 linter: Mark unused disable directive fix as suggestion (#18703) (ddmoney420) - 49609ec linter/no-useless-constructor: Consider argument transformation as used (#18706) (ddmoney420) - 40218de linter: Fix behavior of jsx-a11y/no-static-element-interactions rule. (#17817) (connorshea) - db9751d linter/no-html-link-for-pages: Handle `target=_blank` correctly (#18693) (camc314) - e440b78 linter/plugins: Pass all args to CFG event handlers when 2 rules use same handler (#18683) (overlookmotel) - b393430 linter/curly: Fix multi-or-nest and consistent conflict (#18660) (camc314) - 2e1fbc2 linter/plugins: Implement `context.parserPath` (#18644) (overlookmotel) - 34951ed linter/plugins: `filename` option takes precedence over `parserOptions.lang` in `RuleTester` (#18643) (overlookmotel) - 28df160 linter/plugins: Allow line number passed to `report` to be 0 (#18642) (overlookmotel) - 14fabec vscode: Use built-in `getWorkspaceFolder` for detecting the right workspace of a given uri (#18583) (Sysix) - 0ff4cea oxlint/cli: Report error when nested config could not be parsed (#18504) (Sysix) ### ⚡ Performance - 9862224 linter/plugins: Reduce cost of workspaces (#18758) (overlookmotel) - 6bc0bde linter: Remove string allocation (#18725) (overlookmotel) - 3a6b41e linter/plugins: Replace ESLint Traverser with lightweight traverseNode (#18529) (Rintaro Itokawa) ### 📚 Documentation - dd1a653 linter: Fix doc comment for ignoreStateless config option. (#18808) (connorshea) - 5909085 linter/plugins: Add doc comments (#18753) (overlookmotel) - ffe53a3 linter: Update lint function docs (#18766) (camc314) - b82faec linter: Glob for any css module for no-unassigned-import (#18713) (Ben Stickley) - cd86347 linter: Mark some react rules as unsupported, misc docs improvements (#18617) (connorshea) - 23401d8 linter: Update fixes and suggestions status for tsgolint rules (#18619) (camchenry) # Oxfmt ### 🚀 Features - ee30de9 oxfmt: Add config migration from biome (#18638) (Luca Fischer) ### 🐛 Bug Fixes - e754b18 oxfmt/migrate-prettier: Set `experimentalSortPackagejson: false` by default (#18831) (leaysgur) - a83c266 formatter: Keep decorated function pattern hugged when params break (#18830) (Dunqing) - 0c8efe1 formatter: Quote numeric property keys with `quoteProps: consistent` (#18803) (Dunqing) - 9c14c3e formatter: Ignore comment does not work for sequence expressions in arrow function body (#18799) (Dunqing) - 54984ae formatter: Handle leading comments in arrow function sequence expressions (#18798) (Dunqing) - 61bb2b5 formatter: Correctly expand JSX returned from arrow callbacks in JSX expression containers (#18797) (Dunqing) - 34ee194 formatter: Tailwindcss sorting doesn't work for object property keys (#18773) (Dunqing) - 48f1e35 oxfmt: Prevent ThreadsafeFunction crash on Node.js exit (#18723) (Boshen) - e96adca formatter: Follow Prettier's approach for for-in initializer parentheses (#18695) (Dunqing) - 1215a6f formatter: Preserve quote for class property key in TypeScript (#18692) (Dunqing) - 059acae formatter: Incorrect comments placement for union type in `TSTypeIntersection` (#18690) (Dunqing) - c3d05c1 formatter,oxfmt: Handle CRLF with embedded formatting (#18686) (leaysgur) - 7cb3085 formatter: Preserve comments on rest elements (#18649) (Dunqing) - 21984dd formatter: Preserve type cast comments on rest parameters (#18648) (Dunqing) - 2f70254 formatter: Don't add extra semicolon on suppressed class properties (#18631) (Dunqing) - ac1ff4e oxfmt: Use `empty_line` IR for empty xxx-in-js line (#18623) (leaysgur) - 8f76900 oxfmt: Dedent xxx-in-js templates before calling prettier (#18622) (leaysgur) - 6b726ef oxfmt: Trim whitespace only xxx-in-js templates (#18621) (leaysgur) Co-authored-by: camc314 <[email protected]>

github-actions bot added the A-linter Area - Linter label Jan 30, 2026

github-actions bot added the C-enhancement Category - New feature or request label Jan 30, 2026

camc314 force-pushed the c/01-30-feat_linter_prefer-namespace-keyword_clarify_hard-error_deprecation_note branch from ab2dfd5 to b4c8ff8 Compare January 30, 2026 14:38

github-actions bot added the A-cli Area - CLI label Jan 30, 2026

camc314 changed the title ~~feat(linter/prefer-namespace-keyword): clarify hard-error deprecation note~~ feat(linter/prefer-namespace-keyword): move to correctness Jan 30, 2026

camc314 self-assigned this Jan 30, 2026

camc314 marked this pull request as ready for review January 30, 2026 14:39

Copilot AI review requested due to automatic review settings January 30, 2026 14:39

Copilot started reviewing on behalf of camc314 January 30, 2026 14:39 View session

camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 30, 2026

Copilot AI reviewed Jan 30, 2026

View reviewed changes

crates/oxc_linter/src/rules/typescript/prefer_namespace_keyword.rs Show resolved Hide resolved

camc314 force-pushed the c/01-30-feat_linter_prefer-namespace-keyword_clarify_hard-error_deprecation_note branch 2 times, most recently from 33895d8 to f2363b3 Compare January 30, 2026 14:50

github-actions bot added the A-linter-plugins Area - Linter JS plugins label Jan 30, 2026

feat(linter/prefer-namespace-keyword): move to correctness (#18733)

558b588

this is going to be a hard parser error in a future release, so lets move this rule to correctness to allow people to take advantage of the fixer and migrate their code

graphite-app bot force-pushed the c/01-30-feat_linter_prefer-namespace-keyword_clarify_hard-error_deprecation_note branch from f2363b3 to 558b588 Compare January 30, 2026 14:59

graphite-app bot merged commit 558b588 into main Jan 30, 2026
21 checks passed

graphite-app bot deleted the c/01-30-feat_linter_prefer-namespace-keyword_clarify_hard-error_deprecation_note branch January 30, 2026 15:06

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 30, 2026

Boshen mentioned this pull request Feb 2, 2026

release(apps): oxlint v1.43.0 && oxfmt v0.28.0 #18843

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter/prefer-namespace-keyword): move to correctness#18733

feat(linter/prefer-namespace-keyword): move to correctness#18733
graphite-app[bot] merged 1 commit intomainfrom
c/01-30-feat_linter_prefer-namespace-keyword_clarify_hard-error_deprecation_note

camc314 commented Jan 30, 2026 •

edited

Loading

Uh oh!

camc314 commented Jan 30, 2026

Uh oh!

camc314 commented Jan 30, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Uh oh!

Conversation

camc314 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Jan 30, 2026

How to use the Graphite Merge Queue

Uh oh!

camc314 commented Jan 30, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 30, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

camc314 commented Jan 30, 2026 •

edited

Loading

camc314 commented Jan 30, 2026 •

edited by graphite-app bot

Loading