refactor(formatter): simplify AstNodeIterator and expand impl_ast_node_vec macro#18647
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
Dunqing
force-pushed
the
01-28-refactor_formatter_simplify_astnodeiterator_and_expand_impl_ast_node_vec_macro
branch
2 times, most recently
from
2f06d1e to
cb51764
Compare
Dunqing
force-pushed
the
01-27-fix_formatter_don_t_add_extra_semicolon_on_suppressed_class_properties
branch
from
9c3931a to
beb0b47
Compare
This was referenced Jan 28, 2026
Contributor
Merge activity
|
…node_vec` macro (#18647) Expand `impl_ast_node_vec!` macro to handle `Directive` and `Statement` cases that previously required manual implementations. This will make it easier to handle other nodes that also need to manage the following span of the last item of Vec.
graphite-app
bot
force-pushed
the
01-27-fix_formatter_don_t_add_extra_semicolon_on_suppressed_class_properties
branch
from
beb0b47 to
2f70254
Compare
graphite-app
bot
force-pushed
the
01-28-refactor_formatter_simplify_astnodeiterator_and_expand_impl_ast_node_vec_macro
branch
from
cb51764 to
f4f70bc
Compare
Base automatically changed from
01-27-fix_formatter_don_t_add_extra_semicolon_on_suppressed_class_properties
to
main
January 28, 2026 03:48
graphite-app
bot
deleted the
01-28-refactor_formatter_simplify_astnodeiterator_and_expand_impl_ast_node_vec_macro
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
impl_ast_node_vec!macro to handleDirectiveandStatementcases that previously required manual implementations. This will make it easier to handle other nodes that also need to manage the following span of the last item of Vec.