Skip to content

test(linter/plugins): conformance tests: remove duplicate check#18551

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-25-test_linter_plugins_conformance_tests_remove_duplicate_check
Jan 25, 2026
Merged

test(linter/plugins): conformance tests: remove duplicate check#18551
graphite-app[bot] merged 1 commit intomainfrom
om/01-25-test_linter_plugins_conformance_tests_remove_duplicate_check

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 25, 2026

Pure refactor. This check was being performed twice. Remove the duplicate check.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Jan 25, 2026
Copy link
Member Author

overlookmotel commented Jan 25, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a redundant “custom parser not supported” skip condition from the ESLint conformance test group, relying on the centralized skip logic instead.

Changes:

  • Deleted the per-group skip check for the "Custom parsers are not supported" error in the ESLint conformance group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel self-assigned this Jan 25, 2026
@overlookmotel overlookmotel force-pushed the om/01-25-test_linter_plugins_conformance_tests_remove_duplicate_check branch from b23c5cd to f7300b9 Compare January 25, 2026 21:11
@overlookmotel overlookmotel force-pushed the om/01-25-fix_linter_plugins_keep_infinity_in_rule_default_options branch from 25f80b1 to 0c48617 Compare January 25, 2026 21:11
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 25, 2026

Merge activity

Pure refactor. This check was being performed twice. Remove the duplicate check.
@graphite-app graphite-app bot force-pushed the om/01-25-fix_linter_plugins_keep_infinity_in_rule_default_options branch from 0c48617 to 2acf568 Compare January 25, 2026 21:32
@graphite-app graphite-app bot force-pushed the om/01-25-test_linter_plugins_conformance_tests_remove_duplicate_check branch from f7300b9 to 1685ceb Compare January 25, 2026 21:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
Base automatically changed from om/01-25-fix_linter_plugins_keep_infinity_in_rule_default_options to main January 25, 2026 21:38
@graphite-app graphite-app bot merged commit 1685ceb into main Jan 25, 2026
20 checks passed
@graphite-app graphite-app bot deleted the om/01-25-test_linter_plugins_conformance_tests_remove_duplicate_check branch January 25, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments