style(semantic): reorder diagnostic functions#18540
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 25, 2026
Merged
Conversation
This was referenced Jan 25, 2026
Contributor
Author
This was referenced Jan 25, 2026
github-actions
bot
added
A-parser
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorders accessor-related diagnostic helper functions so that their associated TypeScript error codes appear in numerical order.
Changes:
- Moves
setter_with_optional_parameterso that diagnostics for TS1051, TS1052, and TS1053 are defined in ascending error-code order. - Keeps function bodies and messages unchanged, only adjusting their position and associated
#[cold]attributes accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
force-pushed
the
c/01-25-feat_semantic_add_ts1053_code_to_diagnostic
branch
from
be616f2 to
88ae698
Compare
graphite-app
bot
force-pushed
the
c/01-25-style_semantic_reorder_diagnostic_functions
branch
from
b5c5981 to
232c7f8
Compare
graphite-app
bot
force-pushed
the
c/01-25-feat_semantic_add_ts1053_code_to_diagnostic
branch
from
88ae698 to
1a85484
Compare
graphite-app
bot
force-pushed
the
c/01-25-style_semantic_reorder_diagnostic_functions
branch
from
232c7f8 to
d7f0091
Compare
graphite-app
bot
changed the base branch from
c/01-25-feat_semantic_add_ts1053_code_to_diagnostic
to
graphite-base/18540
camc314
force-pushed
the
c/01-25-style_semantic_reorder_diagnostic_functions
branch
from
d7f0091 to
e1ac5cc
Compare
camc314
force-pushed
the
graphite-base/18540
branch
from
1a85484 to
e4fcdde
Compare
camc314
changed the base branch from
graphite-base/18540
to
c/01-25-feat_semantic_add_ts1053_code_to_diagnostic
This was referenced Jan 25, 2026
Base automatically changed from
c/01-25-feat_semantic_add_ts1053_code_to_diagnostic
to
main
January 25, 2026 19:35
Contributor
Merge activity
|
just reorders the diagnostic functions so the ts error codes are in numerical order
graphite-app
bot
force-pushed
the
c/01-25-style_semantic_reorder_diagnostic_functions
branch
from
e1ac5cc to
823a73c
Compare
graphite-app
bot
deleted the
c/01-25-style_semantic_reorder_diagnostic_functions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just reorders the diagnostic functions so the ts error codes are in numerical order