refactor(semantic): rename diagnosic function name#18536
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 25, 2026
Merged
refactor(semantic): rename diagnosic function name#18536graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Author
github-actions
bot
added
A-parser
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors a diagnostic function name to more accurately describe the underlying error condition for setters in the parser.
Changes:
- Renamed
setter_with_assignment_patterndiagnostic tosetter_with_initializer. - Updated the setter validation logic in
class.rsto use the new diagnostic function.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/oxc_parser/src/js/class.rs |
Updates check_setter to call the renamed setter_with_initializer diagnostic when a TS setter parameter has an initializer. |
crates/oxc_parser/src/diagnostics.rs |
Renames the diagnostic function to setter_with_initializer while keeping the existing error message about disallowing initializers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Merge activity
|
This was referenced Jan 25, 2026
graphite-app
bot
force-pushed
the
c/01-25-feat_semantic_add_ts1049_code_to_diagnostic
branch
from
638dff9 to
8155edf
Compare
graphite-app
bot
force-pushed
the
c/01-25-refactor_semantic_rename_diagnosic_function_name
branch
from
f76f7eb to
5ef8ee5
Compare
Base automatically changed from
c/01-25-feat_semantic_add_ts1049_code_to_diagnostic
to
main
January 25, 2026 18:43
graphite-app
bot
deleted the
c/01-25-refactor_semantic_rename_diagnosic_function_name
branch
This was referenced Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.