Skip to content

refactor(oxlint): move --rules before nested config creation#18515

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-25-refactor_oxlint_move_--rules_before_configstore_creation
Jan 25, 2026
Merged

refactor(oxlint): move --rules before nested config creation#18515
graphite-app[bot] merged 1 commit intomainfrom
01-25-refactor_oxlint_move_--rules_before_configstore_creation

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jan 25, 2026

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 25, 2026
This was referenced Jan 25, 2026
Merged
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Jan 25, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 25, 2026
Merged
Merged
Merged
@Sysix Sysix changed the title refactor(oxlint): move --rules before ConfigStore creation refactor(oxlint): move --rules before nested config creation Jan 25, 2026
@Sysix Sysix requested a review from Copilot January 25, 2026 12:30
Copilot AI reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the oxlint CLI execution flow so --rules is handled immediately after building the root configuration, avoiding unnecessary nested config discovery/creation work for rule-listing runs.

Changes:

  • Build the resolved root lint_config earlier in the command flow.
  • Move --rules output/early-return to occur before nested config discovery.
  • Derive use_cross_module from the resolved lint_config plugins instead of the builder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix marked this pull request as ready for review January 25, 2026 12:47
@Sysix Sysix requested a review from camc314 as a code owner January 25, 2026 12:47
This was referenced Jan 25, 2026
Merged
Merged
@camc314 camc314 self-assigned this Jan 25, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
@camc314 Graphite App
Copy link
Contributor

camc314 commented Jan 25, 2026 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 25, 4:25 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 25, 4:25 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 25, 4:32 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18506.
  • Jan 25, 4:32 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18506.
  • Jan 25, 4:37 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 25, 5:04 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Jan 25, 5:04 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jan 25, 5:05 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jan 25, 5:06 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jan 25, 5:06 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 25, 5:10 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 25, 5:17 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 25, 2026
@graphite-app graphite-app bot changed the base branch from 01-24-refactor_oxlint_move_--print-config_into_a_own_file to graphite-base/18515 January 25, 2026 16:32
graphite-app bot pushed a commit that referenced this pull request Jan 25, 2026
@Sysix
refactor(oxlint): move --rules before nested config creation (#18515)
a063874
@graphite-app graphite-app bot force-pushed the 01-25-refactor_oxlint_move_--rules_before_configstore_creation branch from 76b3c6b to a063874 Compare January 25, 2026 16:38
@github-actions github-actions bot added A-parser Area - Parser A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-linter-plugins Area - Linter JS plugins labels Jan 25, 2026
@graphite-app graphite-app bot changed the base branch from graphite-base/18515 to 01-24-refactor_oxlint_move_--print-config_into_a_own_file January 25, 2026 16:39
Base automatically changed from 01-24-refactor_oxlint_move_--print-config_into_a_own_file to main January 25, 2026 16:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
@camc314 camc314 force-pushed the 01-25-refactor_oxlint_move_--rules_before_configstore_creation branch from a063874 to 76b3c6b Compare January 25, 2026 17:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
@Sysix Sysix force-pushed the 01-25-refactor_oxlint_move_--rules_before_configstore_creation branch from 76b3c6b to 1ed6fd5 Compare January 25, 2026 17:04
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
@graphite-app graphite-app bot force-pushed the 01-25-refactor_oxlint_move_--rules_before_configstore_creation branch from 1ed6fd5 to 4643e9a Compare January 25, 2026 17:11
@graphite-app graphite-app bot merged commit 4643e9a into main Jan 25, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 01-25-refactor_oxlint_move_--rules_before_configstore_creation branch January 25, 2026 17:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins A-minifier Area - Minifier A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sysix @camc314

Comments