refactor(oxlint): move --print-config into a own file#18506
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 25, 2026
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
This was referenced Jan 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the --print-config functionality by extracting it into a dedicated module file, improving code organization and maintainability.
Changes:
- Extracted
--print-configlogic into a newrun_print_configfunction in a separate module - Reorganized the execution flow in
lint.rsto check for--print-configearlier with an early return - Modified ownership patterns to use cloning where needed to support the early return
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src/mode/print_config.rs | New file containing the extracted run_print_config function that handles the --print-config flag |
| apps/oxlint/src/mode/mod.rs | Added module declaration and export for the new print_config module |
| apps/oxlint/src/lint.rs | Refactored to call the extracted run_print_config function earlier in the execution flow, with ownership adjustments to support the early return |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 25, 2026
camc314
approved these changes
Jan 25, 2026
graphite-app
bot
changed the base branch from
01-24-refactor_oxlint_move_--init_logic_into_a_own_file
to
graphite-base/18506
Contributor
Merge activity
|
graphite-app
bot
added
0-merge
camc314
force-pushed
the
01-24-refactor_oxlint_move_--print-config_into_a_own_file
branch
from
f039b0b to
24936c1
Compare
graphite-app
bot
force-pushed
the
01-24-refactor_oxlint_move_--print-config_into_a_own_file
branch
from
24936c1 to
427b730
Compare
graphite-app
bot
deleted the
01-24-refactor_oxlint_move_--print-config_into_a_own_file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.