Skip to content

perf(coverage): simplify architecture and cache test data upfront#18478

Merged
graphite-app[bot] merged 1 commit intomainfrom
refactor/coverage-speedup
Jan 24, 2026
Merged

perf(coverage): simplify architecture and cache test data upfront#18478
graphite-app[bot] merged 1 commit intomainfrom
refactor/coverage-speedup

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Jan 24, 2026

Local: 2.4x faster (31s → 13s)
CI: saved 50s

Copilot AI review requested due to automatic review settings January 24, 2026 11:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 24, 2026
@Boshen Boshen changed the title refactor(coverage): simplify architecture and cache test data upfront perf(coverage): simplify architecture and cache test data upfront Jan 24, 2026
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jan 24, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 24, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing refactor/coverage-speedup (6b043e6) with main (ef7178b)

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 24, 2026
Copy link
Copy Markdown
Member Author

Boshen commented Jan 24, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the refactor/coverage-speedup branch from 6b043e6 to 87684d7 Compare January 24, 2026 11:09
@graphite-app graphite-app bot merged commit 87684d7 into main Jan 24, 2026
22 checks passed
@graphite-app graphite-app bot deleted the refactor/coverage-speedup branch January 24, 2026 11:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 24, 2026
graphite-app bot pushed a commit that referenced this pull request Feb 18, 2026
#18478 removed ESTree conformance tests for `acorn-jsx`. Add it back to conformance tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants