perf(semantic): preserve precomputed identifier hash throughout semantic analysis#18476
Closed
Boshen wants to merge 1 commit into01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexingfrom
Conversation
github-actions
bot
added
A-semantic
This was referenced Jan 24, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Boshen
force-pushed
the
01-24-perf_semantic_preserve_identifier_hash
branch
2 times, most recently
from
e51bb3c to
d788187
Compare
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
from
364ff6d to
db265d1
Compare
Boshen
force-pushed
the
01-24-perf_semantic_preserve_identifier_hash
branch
from
7398f9f to
6a1f84a
Compare
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
from
db265d1 to
ee1560a
Compare
Boshen
force-pushed
the
01-24-perf_semantic_preserve_identifier_hash
branch
from
6a1f84a to
b4a77e0
Compare
Boshen
force-pushed
the
01-24-perf_semantic_preserve_identifier_hash
branch
from
b4a77e0 to
83b24ca
Compare
…tic analysis
- Change `symbol_names` storage from `Vec<Atom>` to `Vec<Ident>` to preserve hash
- Update `create_symbol` and `set_symbol_name` to accept `Ident` instead of `&str`
- Use `clone_in` in scoping methods instead of reconstructing from `&str`
- Update traverse context APIs to use `Ident<'_>` instead of `&str`
- Use `Ident::new_const` for compile-time constant strings ("module", "Object")
- Use `Ident::from(Atom)` instead of `Ident::from(atom.as_str())`
- Modify `base54` to compute hash incrementally while building name, returning `Ident` directly
- Update mangler to use `Ident` throughout, eliminating rehashing of mangled names
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Boshen
force-pushed
the
01-24-perf_semantic_preserve_identifier_hash
branch
from
83b24ca to
99ebd3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symbol_namesstorage fromVec<Atom>toVec<Ident>to preserve hashcreate_symbolandset_symbol_nameto acceptIdentinstead of&strclone_inin scoping methods instead of reconstructing from&strIdent<'_>instead of&strIdentonce per unique name, not per symbolCo-Authored-By: Claude Opus 4.5 [email protected]