perf(semantic): compute identifier hash incrementally during lexing#18454
Closed
Conversation
github-actions
bot
added
A-parser
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging this PR will degrade performance by 20.46%Comparing Summary
Performance Changes
Footnotes
|
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
from
86d7486 to
dca2b3b
Compare
Boshen
force-pushed
the
01-23-refactor_oxc_str_add_incrementalidenthasher_for_byte-by-byte_hash_computation
branch
from
1a13ac9 to
a25cdb3
Compare
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
3 times, most recently
from
2abd0b1 to
364ff6d
Compare
Boshen
force-pushed
the
01-23-refactor_oxc_str_add_incrementalidenthasher_for_byte-by-byte_hash_computation
branch
from
1c918ed to
6d1cc47
Compare
Boshen
changed the title
github-actions
bot
added
A-semantic
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
from
e4e672d to
364ff6d
Compare
Boshen
force-pushed
the
01-23-refactor_oxc_str_add_incrementalidenthasher_for_byte-by-byte_hash_computation
branch
from
6d1cc47 to
fc67309
Compare
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
from
364ff6d to
db265d1
Compare
Add incremental hashing to the lexer so identifier hashes are computed while scanning bytes, avoiding a second pass over the data. - Add `identifier_hasher` field to `Lexer` and `LexerCheckpoint` - Add `hash_identifier: true` variant to `byte_search!` macro - Update `identifier_name_handler` to hash first byte and use hashing variant - Handle unicode/escape cold paths with appropriate hashing - Update `get_ident()` to use `Ident::new_with_hash()` with precomputed hash - Re-export `IncrementalIdentHasher` from `oxc_span` Co-Authored-By: Claude Opus 4.5 <[email protected]>
Boshen
force-pushed
the
01-23-refactor_oxc_str_add_incrementalidenthasher_for_byte-by-byte_hash_computation
branch
from
fc67309 to
ece98da
Compare
Boshen
force-pushed
the
01-23-perf_lexer_compute_identifier_hash_incrementally_during_lexing
branch
from
db265d1 to
ee1560a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add incremental hashing to the lexer so identifier hashes are computed
while scanning bytes, avoiding a second pass over the data.
identifier_hasherfield toLexerandLexerCheckpointhash_identifier: truevariant tobyte_search!macroidentifier_name_handlerto hash first byte and use hashing variantget_ident()to useIdent::new_with_hash()with precomputed hashIncrementalIdentHasherfromoxc_spanCo-Authored-By: Claude Opus 4.5 [email protected]