Skip to content

Comments

refactor(parser): add cur_ident() for identifiers with precomputed hash#18449

Closed
Boshen wants to merge 1 commit into01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsitesfrom
01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash
Closed

refactor(parser): add cur_ident() for identifiers with precomputed hash#18449
Boshen wants to merge 1 commit into01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsitesfrom
01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jan 23, 2026

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 23, 2026
@Boshen Boshen mentioned this pull request Jan 23, 2026
Closed
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jan 23, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen mentioned this pull request Jan 23, 2026
Closed
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash (cceaf1e) with 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites (1b33b59)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites (94c8437) during the generation of this report, so bacc9cf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Boshen Boshen marked this pull request as ready for review January 23, 2026 12:44
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jan 23, 2026 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 23, 12:44 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 23, 12:44 PM UTC: Boshen added this pull request to the Graphite merge queue.
  • Jan 23, 12:47 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18400.
  • Jan 23, 12:47 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18400.

@Boshen Boshen removed the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026
@graphite-app graphite-app bot force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 3a995c4 to 5b77cb7 Compare January 23, 2026 12:45
graphite-app bot pushed a commit that referenced this pull request Jan 23, 2026
@Boshen
refactor(parser): add cur_ident() for identifiers with precomputed ha…
43d0a80 
…sh (#18449)
@graphite-app graphite-app bot force-pushed the 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash branch from b76744a to 43d0a80 Compare January 23, 2026 12:46
@Boshen Boshen force-pushed the 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash branch 2 times, most recently from d1dfda1 to d4ca5d4 Compare January 23, 2026 12:52
This was referenced Jan 23, 2026
Closed
Closed
@Boshen Boshen force-pushed the 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash branch from d4ca5d4 to 046b4e6 Compare January 23, 2026 13:49
@Boshen Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 5b77cb7 to 1b33b59 Compare January 23, 2026 13:49
@Boshen Boshen force-pushed the 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash branch from 046b4e6 to cceaf1e Compare January 24, 2026 03:12
@Boshen Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 1b33b59 to 94c8437 Compare January 24, 2026 03:12
@Boshen Boshen mentioned this pull request Jan 24, 2026
Closed
@Boshen Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 94c8437 to e2c45e1 Compare January 24, 2026 11:16
@Boshen Boshen force-pushed the 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash branch from cceaf1e to f04def0 Compare January 24, 2026 11:16
@Boshen Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from e2c45e1 to b917fbb Compare January 24, 2026 13:41
@Boshen Boshen force-pushed the 01-23-refactor_parser_add_cur_ident_for_identifiers_with_precomputed_hash branch from f04def0 to 26aca72 Compare January 24, 2026 13:41
@Boshen Boshen closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel

@Dunqing Dunqing Awaiting requested review from Dunqing

@camc314 camc314 Awaiting requested review from camc314

Assignees

No one assigned

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Boshen