refactor(semantic): add ArenaIdentHashMap and replace IdentHashMap callsites by Boshen · Pull Request #18425 · oxc-project/oxc

Boshen · 2026-01-23T03:00:39Z

Refactor HashMap to HashMapImpl<'alloc, K, V, H> generic over hasher
Add ArenaIdentHashMap for arena-allocated hash maps keyed by Ident
Replace FxHashMap<Atom> with IdentHashMap in semantic and isolated_declarations
Update linter snapshots for iteration order changes

Co-Authored-By: Claude Opus 4.5 [email protected]

Boshen · 2026-01-23T03:01:04Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-01-23T03:06:26Z

Merging this PR will improve performance by 8.3%

⚡ 4 improved benchmarks
✅ 38 untouched benchmarks
⏩ 3 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`isolated-declarations[vue-id.ts]`	56.9 ms	54.6 ms	+4.14%
⚡	Simulation	`semantic[react.development.js]`	1.3 ms	1.2 ms	+6.62%
⚡	Simulation	`semantic[binder.ts]`	3.2 ms	2.9 ms	+8.3%
⚡	Simulation	`semantic[cal.com.tsx]`	21.4 ms	20.8 ms	+3.14%

_{Comparing 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites (94c8437) with refactor/ident-precomputed-hash (ec7dd07)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

graphite-app · 2026-01-23T12:44:46Z

Merge activity

Jan 23, 12:44 PM UTC: Boshen added this pull request to the Graphite merge queue.
Jan 23, 12:47 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18400.
Jan 23, 12:47 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #18400.

…llsites (#18425) - Refactor `HashMap` to `HashMapImpl<'alloc, K, V, H>` generic over hasher - Add `ArenaIdentHashMap` for arena-allocated hash maps keyed by `Ident` - Replace `FxHashMap<Atom>` with `IdentHashMap` in semantic and isolated_declarations - Update linter snapshots for iteration order changes Co-Authored-By: Claude Opus 4.5 <[email protected]>

github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-ast Area - AST A-isolated-declarations Isolated Declarations labels Jan 23, 2026

Boshen mentioned this pull request Jan 23, 2026

feat(oxc_str): upgrade Ident with precomputed hash for fast equality #18400

Closed

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 08e889e to 298d44e Compare January 23, 2026 04:23

github-actions bot added the A-transformer Area - Transformer / Transpiler label Jan 23, 2026

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from b334746 to 051ad87 Compare January 23, 2026 05:15

Boshen changed the title ~~refactor: add ArenaIdentHashMap and replace IdentHashMap callsites~~ refactor(semantic): add ArenaIdentHashMap and replace IdentHashMap callsites Jan 23, 2026

github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 23, 2026

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 051ad87 to c71b25b Compare January 23, 2026 08:14

Boshen force-pushed the refactor/ident-precomputed-hash branch from 1e0f0a9 to 4b0ab24 Compare January 23, 2026 08:14

Boshen marked this pull request as ready for review January 23, 2026 08:14

Boshen requested review from Dunqing, camc314 and overlookmotel as code owners January 23, 2026 08:14

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from c71b25b to 9a4dfd0 Compare January 23, 2026 08:35

Boshen force-pushed the refactor/ident-precomputed-hash branch from 4b0ab24 to c731466 Compare January 23, 2026 08:45

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 9a4dfd0 to 3a995c4 Compare January 23, 2026 08:45

Boshen mentioned this pull request Jan 23, 2026

refactor(parser): add cur_ident() for identifiers with precomputed hash #18449

Closed

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026

graphite-app bot force-pushed the refactor/ident-precomputed-hash branch from c731466 to cb0beca Compare January 23, 2026 12:45

graphite-app bot force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 3a995c4 to 5b77cb7 Compare January 23, 2026 12:45

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026

This was referenced Jan 23, 2026

refactor(oxc_str): add IncrementalIdentHasher for byte-by-byte hash computation #18451

Closed

perf(semantic): compute identifier hash incrementally during lexing #18454

Closed

Boshen force-pushed the refactor/ident-precomputed-hash branch from cb0beca to de43879 Compare January 23, 2026 13:49

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 5b77cb7 to 1b33b59 Compare January 23, 2026 13:49

Boshen force-pushed the refactor/ident-precomputed-hash branch from de43879 to ec7dd07 Compare January 24, 2026 03:12

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 1b33b59 to 94c8437 Compare January 24, 2026 03:12

Boshen mentioned this pull request Jan 24, 2026

perf(semantic): preserve precomputed identifier hash throughout semantic analysis #18476

Closed

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from 94c8437 to e2c45e1 Compare January 24, 2026 11:16

Boshen force-pushed the refactor/ident-precomputed-hash branch from ec7dd07 to a2af5d6 Compare January 24, 2026 11:16

Boshen force-pushed the refactor/ident-precomputed-hash branch from a2af5d6 to f460a88 Compare January 24, 2026 13:41

Boshen force-pushed the 01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites branch from e2c45e1 to b917fbb Compare January 24, 2026 13:41

Boshen closed this Feb 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(semantic): add ArenaIdentHashMap and replace IdentHashMap callsites#18425

refactor(semantic): add ArenaIdentHashMap and replace IdentHashMap callsites#18425
Boshen wants to merge 1 commit intorefactor/ident-precomputed-hashfrom
01-23-refactor_add_arenaidenthashmap_and_replace_identhashmap_callsites

Boshen commented Jan 23, 2026

Uh oh!

Boshen commented Jan 23, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Uh oh!

Conversation

Boshen commented Jan 23, 2026

Uh oh!

Boshen commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 8.3%

Performance Changes

Footnotes

Uh oh!

graphite-app bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Boshen commented Jan 23, 2026 •

edited

Loading

codspeed-hq bot commented Jan 23, 2026 •

edited

Loading

graphite-app bot commented Jan 23, 2026 •

edited

Loading