Skip to content

chore(linter): Create a JSON file for Vitest-compatible Jest rules.#18414

Merged
graphite-app[bot] merged 1 commit intomainfrom
update-vitest-rules-list-to-json
Jan 23, 2026
Merged

chore(linter): Create a JSON file for Vitest-compatible Jest rules.#18414
graphite-app[bot] merged 1 commit intomainfrom
update-vitest-rules-list-to-json

Conversation

@connorshea
Copy link
Copy Markdown
Member

@connorshea connorshea commented Jan 23, 2026

This is intended to match the existing constant in the codebase exactly, and will be used for oxlint-migrate and eslint-plugin-oxlint to get rid of some tedious busywork with keeping the projects in sync.

Fixes #18413

See oxc-project/oxlint-migrate#344 for the companion PR in oxlint-migrate.

@connorshea connorshea requested a review from camc314 as a code owner January 23, 2026 00:33
Copilot AI review requested due to automatic review settings January 23, 2026 00:33
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR creates a JSON file containing the list of Vitest-compatible Jest rules to enable automation of rule updates across the oxc ecosystem. The JSON file serves as a machine-readable version of the existing Rust constant, allowing external tools (oxlint-migrate and eslint-plugin-oxlint) to programmatically access the rule list without manual synchronization.

Changes:

  • Added a new JSON file containing the 41 Vitest-compatible Jest rules
  • Updated comments in the Rust code to reference the new JSON file instead of the external oxlint-migrate repository
  • Added a comprehensive test to ensure the JSON file stays synchronized with the Rust constant

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/data/vitest_compatible_jest_rules.json New JSON file containing the alphabetized list of 41 Vitest-compatible Jest rules, matching the existing Rust constant
crates/oxc_linter/src/utils/mod.rs Updated comments to reference the JSON file and added a test to enforce synchronization between the JSON and Rust constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 23, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing update-vitest-rules-list-to-json (a2ba9a7) with main (e046ea6)

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026
Copy link
Copy Markdown
Member

camchenry commented Jan 23, 2026

Merge activity

…18414)

This is intended to match the existing constant in the codebase exactly, and will be used for oxlint-migrate and eslint-plugin-oxlint to get rid of some tedious busywork with keeping the projects in sync.

Fixes #18413

See oxc-project/oxlint-migrate#344 for the companion PR in oxlint-migrate.
@graphite-app graphite-app bot force-pushed the update-vitest-rules-list-to-json branch from a2ba9a7 to 0ffb5e9 Compare January 23, 2026 15:03
@graphite-app graphite-app bot merged commit 0ffb5e9 into main Jan 23, 2026
21 checks passed
@graphite-app graphite-app bot deleted the update-vitest-rules-list-to-json branch January 23, 2026 15:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026
Sysix pushed a commit to oxc-project/eslint-plugin-oxlint that referenced this pull request Jan 27, 2026
…ases (#619)

See oxc-project/oxc#18413 for the concept, and
oxc-project/oxc#18414 for the PR where I
implemented this in the oxc repo.

This was generated with help from Claude Code by having it basically
reproduce the changes from
oxc-project/oxlint-migrate#344 in this repo.

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: Automate updates for compatible rules in the @oxlint/migrate and eslint-plugin-oxlint repos

3 participants