perf(semantic): skip parent lookup for function declarations in Function::bind#18293
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 21, 2026
Conversation
github-actions
bot
added
A-semantic
This was referenced Jan 20, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 20, 2026
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a micro-optimization in the semantic analysis binder for functions. It avoids an unnecessary parent node lookup for function declarations when checking if a function is an object property method/getter/setter.
Changes:
- Cache
is_declaration()result in a variable at the start ofFunction::bind - Add an early-exit check
!is_declarationbefore performing parent node lookup forObjectProperty - Reuse the cached
is_declarationvalue for the existing conditional check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing 
Footnotes
|
This was referenced Jan 20, 2026
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
om/01-20-perf_semantic_move_check_for_function_declaration_out_of_is_function_part_of_if_statement_
branch
from
c9cc4ad to
8dccef1
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…tion::bind` (#18293) Small optimization. `Function::bind` checks is the parent node is an `ObjectProperty` (i.e. the function is a method/getter/setter). Skip this check for function declarations, since they can't be methods.
graphite-app
bot
force-pushed
the
om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_
branch
from
a98ef27 to
948e0a7
Compare
Dunqing
approved these changes
Jan 21, 2026
graphite-app
bot
added
0-merge
…tion::bind` (#18293) Small optimization. `Function::bind` checks is the parent node is an `ObjectProperty` (i.e. the function is a method/getter/setter). Skip this check for function declarations, since they can't be methods.
graphite-app
bot
force-pushed
the
om/01-20-perf_semantic_move_check_for_function_declaration_out_of_is_function_part_of_if_statement_
branch
from
953be9e to
c27ad2d
Compare
graphite-app
bot
force-pushed
the
om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_
branch
from
948e0a7 to
6b600c4
Compare
Base automatically changed from
om/01-20-perf_semantic_move_check_for_function_declaration_out_of_is_function_part_of_if_statement_
to
main
January 21, 2026 02:08
graphite-app
bot
deleted the
om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_
branch
overlookmotel
pushed a commit
that referenced
this pull request
Jan 26, 2026
### 💥 BREAKING CHANGES - 22dec6a semantic: [**BREAKING**] Remove `Scoping::scope_build_child_ids` and all related APIs (#18362) (Dunqing) - 30a4899 oxc: [**BREAKING**] Remove `CompilerInterface::semantic_child_scope_ids` (#18361) (Dunqing) - 777fc40 ast: [**BREAKING**] Add `Ident` type (#18354) (Boshen) - af0ca46 span: [**BREAKING**] Use `ModuleKind::CommonJS` for `SourceType::cjs()` (#18276) (sapphi-red) ### 🚀 Features - 0a02026 semantic: Add TS1499 code to diagnostic (#18557) (camc314) - 8b4618f parser: Add TS1500 code to diagnostic (#18547) (camc314) - 866b6b3 parser: Add TS1048 code to diagnostic (#18546) (camc314) - 1117c44 parser: Add TS1054 code to diagnostic (#18541) (camc314) - e4fcdde semantic: Add TS1053 code to diagnostic (#18539) (camc314) - bcbf396 semantic: Add TS1052 code to diagnostic (#18538) (camc314) - 8155edf semantic: Add TS1049 code to diagnostic (#18535) (camc314) - 51d3b3f parser: Add TS1502 code to diagnostic (#18534) (camc314) - 00854e8 semantic: Add TS2337 error code to super call diagnostic (#18531) (camc314) - 993fd2b parser: Parse unambiguous await with better error messages (#18480) (Boshen) - 8db0e78 linter/plugins: Handle BOMs (#18376) (overlookmotel) - 6ac09e2 linter/plugins: Support source text not being at start of buffer (#18375) (overlookmotel) - 2ef5647 ast: Add escape_raw parameter to template_element builders (#18121) (Boshen) ### 🐛 Bug Fixes - 74d0998 semantic: Update error msg for multiple `default` cases in switch stmt (#18526) (camc314) - c205b0d ast: Remove `ThisExpression` from `TSModuleReference` (#18489) (Boshen) - aed3669 parser: Parse HTML-like comments in unambiguous mode (#18442) (Boshen) - c4132fb parser: Validate accessor parameters in interface method signatures (#18391) (Boshen) - b0cd74d semantic: Allow `var` and `function` with same name in static blocks (#18358) (Boshen) - 6037995 semantic: Allow `new.target` in class field initializers (#18349) (Boshen) - 9a15c6a semantic: Do not rely on spans for node comparison in `Function::bind` (#18296) (overlookmotel) ### ⚡ Performance - 6b600c4 semantic: Skip parent lookup for function declarations in `Function::bind` (#18293) (overlookmotel) - c27ad2d semantic: Move check for function declaration out of `is_function_part_of_if_statement` (#18292) (overlookmotel) - 63eb89e semantic: Skip checking redeclarations for function expressions (#18291) (overlookmotel) - 7c12743 semantic: Skip checking unresolved exports in CommonJS files (#18250) (overlookmotel) - 2349031 allocator: Increase initial chunk size from 512B to 16KB (#18234) (Boshen) ### 📚 Documentation - 8ccd853 npm: Update package homepage URLs and add keywords (#18509) (Boshen) - 9b3165f napi/parser: Clarify when to use `parseAsync` vs `parseSync` (#18486) (Boshen) - 1b59f63 napi/parser: Correct typo in README (#18251) (overlookmotel) - 00ff75f mangler: Fix `top_level` option in example (#18233) (overlookmotel) - 2ddc073 semantic: Fix typo in comment (#18238) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization.
Function::bindchecks is the parent node is anObjectProperty(i.e. the function is a method/getter/setter). Skip this check for function declarations, since they can't be methods.