Skip to content

refactor(minifier): turn off scope_tree_child_ids for SemanticBuilder#18241

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder
Jan 22, 2026
Merged

refactor(minifier): turn off scope_tree_child_ids for SemanticBuilder#18241
graphite-app[bot] merged 1 commit intomainfrom
01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 19, 2026 •
edited
Loading

I didn't see any scope_tree_child_ids related API calls in the minifier, so turn it off.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 19, 2026
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Jan 19, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks1

Comparing 01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder (a9c306c) with 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder (3f3bc6d)2

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder (cfad64b) during the generation of this report, so ab9f23f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This was referenced Jan 21, 2026
Merged
Merged
@Dunqing Dunqing changed the base branch from main to graphite-base/18241 January 21, 2026 16:21
@Dunqing Dunqing force-pushed the 01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder branch from 72b0982 to 1df310a Compare January 21, 2026 16:21
@Dunqing Dunqing changed the base branch from graphite-base/18241 to 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder January 21, 2026 16:21
This was referenced Jan 21, 2026
Merged
Merged
Merged
@Dunqing Dunqing force-pushed the 01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder branch from 1df310a to 54e7256 Compare January 21, 2026 16:30
@Dunqing Dunqing force-pushed the 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder branch from de5aa5d to 3f3bc6d Compare January 21, 2026 16:30
@Dunqing Dunqing marked this pull request as ready for review January 22, 2026 03:44
@Dunqing Dunqing requested a review from overlookmotel January 22, 2026 03:45
@Dunqing Dunqing force-pushed the 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder branch from 3f3bc6d to cfad64b Compare January 22, 2026 03:52
@Dunqing Dunqing force-pushed the 01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder branch from 54e7256 to a9c306c Compare January 22, 2026 03:52
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 22, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 22, 2026 •
edited
Loading

Merge activity

@Dunqing
refactor(minifier): turn off scope_tree_child_ids for `SemanticBuil…
11c8b54 
…der` (#18241)

I didn't see any `scope_tree_child_ids` related API calls in the minifier, so turn it off.
@graphite-app graphite-app bot force-pushed the 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder branch from cfad64b to 07618a7 Compare January 22, 2026 06:34
@graphite-app graphite-app bot requested a review from camc314 as a code owner January 22, 2026 06:34
@graphite-app graphite-app bot force-pushed the 01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder branch from a9c306c to 11c8b54 Compare January 22, 2026 06:34
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 22, 2026
Base automatically changed from 01-21-perf_linter_turn_off_scope_build_child_ids_for_semanticbuilder to main January 22, 2026 07:00
@graphite-app graphite-app bot merged commit 11c8b54 into main Jan 22, 2026
22 checks passed
@graphite-app graphite-app bot deleted the 01-19-refactor_minifier_turn_off_scope_tree_child_ids_for_semanticbuilder branch January 22, 2026 07:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel

@camc314 camc314 Awaiting requested review from camc314

Assignees

@overlookmotel overlookmotel

Labels

A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing @overlookmotel

Comments