Skip to content

docs(semantic): fix typo in comment#18238

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-19-docs_semantic_fix_typo_in_comment
Jan 19, 2026
Merged

docs(semantic): fix typo in comment#18238
graphite-app[bot] merged 1 commit intomainfrom
om/01-19-docs_semantic_fix_typo_in_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 19, 2026

Just fix a typo in a comment. check_redeclaration not check_redelcaration.

Also add full stops to the ends of sentences.

@github-actions github-actions bot added A-semantic Area - Semantic C-docs Category - Documentation. Related to user-facing or internal documentation labels Jan 19, 2026
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review January 19, 2026 13:17
Copilot AI review requested due to automatic review settings January 19, 2026 13:17
@overlookmotel overlookmotel self-assigned this Jan 19, 2026
@overlookmotel overlookmotel removed the request for review from Dunqing January 19, 2026 13:17
@overlookmotel
Copy link
Member Author

Trivial change, so will merge without review. But waiting to get the release out first.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a typo in a comment and improves grammar by adding proper punctuation. The comment references the check_redeclaration function, which was misspelled as check_redelcaration.

Changes:

  • Corrected spelling of check_redeclaration in a comment
  • Added periods to the end of comment sentences for proper grammar

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing om/01-19-docs_semantic_fix_typo_in_comment (7e3c4ff) with main (645c3f0)1

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks2

Footnotes

  1. No successful run was found on main (62a00e5) during the generation of this report, so 645c3f0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Copy link
Member

Boshen commented Jan 19, 2026

Merge activity

graphite-app bot pushed a commit that referenced this pull request Jan 19, 2026
Just fix a typo in a comment. `check_redeclaration` not `check_redelcaration`.

Also add full stops to the ends of sentences.
@graphite-app graphite-app bot force-pushed the om/01-19-docs_semantic_fix_typo_in_comment branch from 7e3c4ff to 98d0cb1 Compare January 19, 2026 13:40
Just fix a typo in a comment. `check_redeclaration` not `check_redelcaration`.

Also add full stops to the ends of sentences.
@graphite-app graphite-app bot force-pushed the om/01-19-docs_semantic_fix_typo_in_comment branch from 98d0cb1 to 2ddc073 Compare January 19, 2026 13:43
@graphite-app graphite-app bot merged commit 2ddc073 into main Jan 19, 2026
21 checks passed
@graphite-app graphite-app bot deleted the om/01-19-docs_semantic_fix_typo_in_comment branch January 19, 2026 13:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
overlookmotel pushed a commit that referenced this pull request Jan 26, 2026
### 💥 BREAKING CHANGES

- 22dec6a semantic: [**BREAKING**] Remove
`Scoping::scope_build_child_ids` and all related APIs (#18362) (Dunqing)
- 30a4899 oxc: [**BREAKING**] Remove
`CompilerInterface::semantic_child_scope_ids` (#18361) (Dunqing)
- 777fc40 ast: [**BREAKING**] Add `Ident` type (#18354) (Boshen)
- af0ca46 span: [**BREAKING**] Use `ModuleKind::CommonJS` for
`SourceType::cjs()` (#18276) (sapphi-red)

### 🚀 Features

- 0a02026 semantic: Add TS1499 code to diagnostic (#18557) (camc314)
- 8b4618f parser: Add TS1500 code to diagnostic (#18547) (camc314)
- 866b6b3 parser: Add TS1048 code to diagnostic (#18546) (camc314)
- 1117c44 parser: Add TS1054 code to diagnostic (#18541) (camc314)
- e4fcdde semantic: Add TS1053 code to diagnostic (#18539) (camc314)
- bcbf396 semantic: Add TS1052 code to diagnostic (#18538) (camc314)
- 8155edf semantic: Add TS1049 code to diagnostic (#18535) (camc314)
- 51d3b3f parser: Add TS1502 code to diagnostic (#18534) (camc314)
- 00854e8 semantic: Add TS2337 error code to super call diagnostic
(#18531) (camc314)
- 993fd2b parser: Parse unambiguous await with better error messages
(#18480) (Boshen)
- 8db0e78 linter/plugins: Handle BOMs (#18376) (overlookmotel)
- 6ac09e2 linter/plugins: Support source text not being at start of
buffer (#18375) (overlookmotel)
- 2ef5647 ast: Add escape_raw parameter to template_element builders
(#18121) (Boshen)

### 🐛 Bug Fixes

- 74d0998 semantic: Update error msg for multiple `default` cases in
switch stmt (#18526) (camc314)
- c205b0d ast: Remove `ThisExpression` from `TSModuleReference` (#18489)
(Boshen)
- aed3669 parser: Parse HTML-like comments in unambiguous mode (#18442)
(Boshen)
- c4132fb parser: Validate accessor parameters in interface method
signatures (#18391) (Boshen)
- b0cd74d semantic: Allow `var` and `function` with same name in static
blocks (#18358) (Boshen)
- 6037995 semantic: Allow `new.target` in class field initializers
(#18349) (Boshen)
- 9a15c6a semantic: Do not rely on spans for node comparison in
`Function::bind` (#18296) (overlookmotel)

### ⚡ Performance

- 6b600c4 semantic: Skip parent lookup for function declarations in
`Function::bind` (#18293) (overlookmotel)
- c27ad2d semantic: Move check for function declaration out of
`is_function_part_of_if_statement` (#18292) (overlookmotel)
- 63eb89e semantic: Skip checking redeclarations for function
expressions (#18291) (overlookmotel)
- 7c12743 semantic: Skip checking unresolved exports in CommonJS files
(#18250) (overlookmotel)
- 2349031 allocator: Increase initial chunk size from 512B to 16KB
(#18234) (Boshen)

### 📚 Documentation

- 8ccd853 npm: Update package homepage URLs and add keywords (#18509)
(Boshen)
- 9b3165f napi/parser: Clarify when to use `parseAsync` vs `parseSync`
(#18486) (Boshen)
- 1b59f63 napi/parser: Correct typo in README (#18251) (overlookmotel)
- 00ff75f mangler: Fix `top_level` option in example (#18233)
(overlookmotel)
- 2ddc073 semantic: Fix typo in comment (#18238) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments