feat(napi/parser, napi/transform): accept sourceType: "commonjs"#18197
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 19, 2026
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 18, 2026
overlookmotel
force-pushed
the
om/01-18-feat_napi_parser_napi_transform_accept_sourcetype_commonjs_
branch
from
3b38774 to
ef08b7c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends support for the commonjs source type to NAPI packages (oxc-parser and oxc-transform), building on the parser support added in #18089. The change allows users to explicitly specify sourceType: 'commonjs' when parsing or transforming code.
Changes:
- Updated TypeScript type definitions across parser, transform, and oxlint packages to include
'commonjs'as a validsourceTypeoption - Added implementation support in the shared
get_source_typefunction to handle the'commonjs'case - Added comprehensive test coverage for the new
commonjssource type in the parser package
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
napi/transform/src/transformer.rs |
Updated TypeScript type annotation to include 'commonjs' option |
napi/transform/index.d.ts |
Updated TypeScript interface to include 'commonjs' in sourceType union |
napi/parser/test/parse.test.ts |
Added comprehensive tests for sourceType: 'commonjs' across all language types |
napi/parser/src/types.rs |
Updated TypeScript type annotation to include 'commonjs' option |
napi/parser/src-js/index.d.ts |
Updated TypeScript interface to include 'commonjs' in sourceType union |
crates/oxc_napi/src/lib.rs |
Added commonjs case handling in get_source_type function and minor documentation improvement |
apps/oxlint/src/js_plugins/parse.rs |
Updated TypeScript type annotation to include 'commonjs' option |
apps/oxlint/src-js/bindings.d.ts |
Updated TypeScript interface to include 'commonjs' in sourceType union |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
requested review from
Boshen and
Dunqing
and removed request for
Boshen
graphite-app
bot
changed the base branch from
om/01-18-test_linter_plugins_fix_tests_for_ruletester_ignorenonfatalerrors_option
to
graphite-base/18197
graphite-app
bot
force-pushed
the
graphite-base/18197
branch
from
4d0e4d0 to
ff4edd2
Compare
graphite-app
bot
force-pushed
the
om/01-18-feat_napi_parser_napi_transform_accept_sourcetype_commonjs_
branch
from
ef08b7c to
80fc51f
Compare
graphite-app
bot
force-pushed
the
om/01-18-feat_napi_parser_napi_transform_accept_sourcetype_commonjs_
branch
from
80fc51f to
9a5146e
Compare
Dunqing
approved these changes
Jan 19, 2026
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
om/01-18-feat_napi_parser_napi_transform_accept_sourcetype_commonjs_
branch
from
9a5146e to
6e8fa80
Compare
graphite-app
bot
deleted the
om/01-18-feat_napi_parser_napi_transform_accept_sourcetype_commonjs_
branch
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18089 added support in parser for
commonjssource type.Extend this support to the NAPI packages - accept
sourceType: 'commonjs'in options foroxc-parserandoxc-transform.