fix(linter): Update react/jsx-max-depth to raise an error if provided invalid config options.#18105
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the react/jsx-max-depth linter rule to properly raise errors when provided with invalid configuration options. The fix was missed in #18104 because this rule used a slightly different pattern in its from_configuration method. The PR also adds documentation for the configuration field.
Changes:
- Added
deny_unknown_fieldsattribute to reject unknown configuration fields - Added documentation for the
maxconfiguration field - Updated
from_configurationto properly propagate errors instead of silently defaulting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
graphite-app
bot
force-pushed
the
jsx-max-depth-rule-valid
branch
from
761ef73 to
5f98e1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not handled by #18104 as the rule was using a slightly different pattern for the from_configuration method compared to other rules, so it was missed by the scripts I used.
Also add docs, why not.