feat(linter): Add support for no constructed context values by JoviDeCroock · Pull Request #18067 · oxc-project/oxc

JoviDeCroock · 2026-01-16T07:54:17Z

Relates to #1022

This rule is quite important for performance reasons, when we always create a new object/array/... in the value property it means we'll be propagating updates to all subscribers every time the Provider component re-renders.

JoviDeCroock · 2026-01-16T08:06:56Z

Eh, I screwed up the branch sorry the auto-fix ci thing threw me off

codspeed-hq · 2026-01-16T08:10:21Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing JoviDeCroock:support-no-constructed-context-values (7f48422) with main (f2440eb)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

This PR adds a new React linter rule jsx-no-constructed-context-values to detect performance issues caused by constructed values in Context Provider components. When objects, arrays, or functions are created inline in the value prop, React Context will trigger unnecessary rerenders of all consumers on each render cycle.

Changes:

Implements jsx-no-constructed-context-values rule to flag inline constructed values in Context.Provider components
Detects various constructed expressions including object literals, array literals, function expressions, and locally-defined functions
Excludes values wrapped in useMemo or useCallback hooks, and top-level declarations

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/rules/react/jsx_no_constructed_context_values.rs	Core rule implementation with expression analysis, scope tracking, and comprehensive test cases
crates/oxc_linter/src/rules.rs	Registers the new rule module in the React rules collection
crates/oxc_linter/src/generated/rule_runner_impls.rs	Auto-generated rule runner implementation for JSXOpeningElement nodes
crates/oxc_linter/src/snapshots/react_jsx_no_constructed_context_values.snap	Snapshot tests showing expected diagnostic outputs for various violation scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_linter/src/rules/react/jsx_no_constructed_context_values.rs

camchenry

Thank you so much for the contribution! I had a few small suggestions, but nothing major, since this rule isn't too complicated.

You'll also need to merge main again and run cargo lintgen to fix the merge conflicts in rules_enum.rs (feel free to just delete the whole file and run cargo lintgen). Sorry about that, it's a little bit more of a pain with merge conflicts for now until we improve it. Once that's done and the PR is updated, we can get this merged in. 😄

crates/oxc_linter/src/rules/react/jsx_no_constructed_context_values.rs

camchenry

Thank you!

graphite-app · 2026-02-13T15:43:19Z

Merge activity

Feb 13, 3:43 PM UTC: @JoviDeCroock we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

…ect#18067) Relates to oxc-project#1022 This rule is quite important for performance reasons, when we always create a new object/array/... in the `value` property it means we'll be propagating updates to all subscribers every time the Provider component re-renders.

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (oxc-project#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (oxc-project#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (oxc-project#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (oxc-project#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (oxc-project#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (oxc-project#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (oxc-project#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (oxc-project#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (oxc-project#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (oxc-project#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (oxc-project#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (oxc-project#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (oxc-project#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (oxc-project#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (oxc-project#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (oxc-project#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (oxc-project#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (oxc-project#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (oxc-project#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (oxc-project#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (oxc-project#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (oxc-project#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (oxc-project#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (oxc-project#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (oxc-project#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (oxc-project#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (oxc-project#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (oxc-project#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (oxc-project#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (oxc-project#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (oxc-project#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (oxc-project#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (oxc-project#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (oxc-project#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (oxc-project#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (oxc-project#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (oxc-project#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (oxc-project#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (oxc-project#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (oxc-project#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red)

github-actions bot added the A-linter Area - Linter label Jan 16, 2026

JoviDeCroock changed the title ~~Add support for no constructed context values~~ feat: Add support for no constructed context values Jan 16, 2026

JoviDeCroock changed the title ~~feat: Add support for no constructed context values~~ feat(oxlint) Add support for no constructed context values Jan 16, 2026

JoviDeCroock changed the title ~~feat(oxlint) Add support for no constructed context values~~ feat(linter): Add support for no constructed context values Jan 16, 2026

github-actions bot added the C-enhancement Category - New feature or request label Jan 16, 2026

JoviDeCroock force-pushed the support-no-constructed-context-values branch from 13cf037 to 8147fee Compare January 16, 2026 08:04

github-actions bot added the A-formatter Area - Formatter label Jan 16, 2026

JoviDeCroock force-pushed the support-no-constructed-context-values branch from 8147fee to e95afff Compare January 16, 2026 08:05

JoviDeCroock force-pushed the support-no-constructed-context-values branch from e95afff to 2de3b38 Compare January 16, 2026 08:10

JoviDeCroock force-pushed the support-no-constructed-context-values branch 2 times, most recently from 9ccd76c to dc544ed Compare January 16, 2026 08:44

JoviDeCroock marked this pull request as ready for review January 16, 2026 08:55

JoviDeCroock requested a review from camc314 as a code owner January 16, 2026 08:55

Copilot AI review requested due to automatic review settings January 16, 2026 08:55

Copilot started reviewing on behalf of JoviDeCroock January 16, 2026 08:56 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

baevm reviewed Jan 18, 2026

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_no_constructed_context_values.rs Show resolved Hide resolved

JoviDeCroock force-pushed the support-no-constructed-context-values branch 8 times, most recently from b7d0572 to b27dd50 Compare January 21, 2026 17:21

leaysgur removed the A-formatter Area - Formatter label Jan 24, 2026

camchenry reviewed Feb 13, 2026

View reviewed changes

Add support for no-constructed context value

7f48422

JoviDeCroock force-pushed the support-no-constructed-context-values branch from b27dd50 to 7f48422 Compare February 13, 2026 15:32

JoviDeCroock requested a review from camchenry February 13, 2026 15:33

camchenry approved these changes Feb 13, 2026

View reviewed changes

camchenry added the 0-merge Merge with Graphite Merge Queue label Feb 13, 2026

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 13, 2026

camchenry merged commit ea2c401 into oxc-project:main Feb 13, 2026
29 checks passed

Boshen mentioned this pull request Feb 16, 2026

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): Add support for no constructed context values#18067

feat(linter): Add support for no constructed context values#18067
camchenry merged 1 commit intooxc-project:mainfrom
JoviDeCroock:support-no-constructed-context-values

JoviDeCroock commented Jan 16, 2026

Uh oh!

JoviDeCroock commented Jan 16, 2026

Uh oh!

codspeed-hq bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

camchenry left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camchenry left a comment

Uh oh!

graphite-app bot commented Feb 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Uh oh!

Conversation

JoviDeCroock commented Jan 16, 2026

Uh oh!

JoviDeCroock commented Jan 16, 2026

Uh oh!

codspeed-hq bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

camchenry left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camchenry left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Feb 13, 2026

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

codspeed-hq bot commented Jan 16, 2026 •

edited

Loading

camchenry left a comment •

edited

Loading