refactor(linter, mangler): get reference scope by reference.scope_id()#18059
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 19, 2026
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will improve performance by 20.89%
Performance Changes
Comparing 
Footnotes
|
This was referenced Jan 17, 2026
Dunqing
changed the base branch from
01-16-feat_semantic_store_scope_id_in_reference
to
graphite-base/18059
Dunqing
force-pushed
the
graphite-base/18059
branch
from
3ce0bac to
a4f011a
Compare
Dunqing
force-pushed
the
01-16-refactor_linter_mangler_get_reference_scope_by_reference.scope_id_
branch
from
7c4f44f to
17591fa
Compare
Dunqing
changed the base branch from
graphite-base/18059
to
01-16-feat_semantic_store_scope_id_in_reference
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
rolldown/rolldown#7936 relies on this. You can see how Rolldown uses this at description of that PR. Additionally, it can also simplify the use case when you want to get the scope ID where the `Reference` occurs. See follow-up PR #18059
graphite-app
bot
force-pushed
the
01-16-feat_semantic_store_scope_id_in_reference
branch
from
a4f011a to
e2221e6
Compare
graphite-app
bot
force-pushed
the
01-16-refactor_linter_mangler_get_reference_scope_by_reference.scope_id_
branch
from
17591fa to
727939f
Compare
Base automatically changed from
01-16-feat_semantic_store_scope_id_in_reference
to
main
January 19, 2026 05:00
graphite-app
bot
deleted the
01-16-refactor_linter_mangler_get_reference_scope_by_reference.scope_id_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the use cases mentioned in #18053. After that PR, we can access the
scope_iddirectly from theReference, eliminating the need for an intermediate step to get the node first.😅: I didn't expect there would be a lot of performance improvement in the Mangler.