feat(linter): implement eslint-plugin-vitest/prefer-called-exactly-once-with by Afsoon · Pull Request #17562 · oxc-project/oxc

Afsoon · 2026-01-01T16:17:11Z

Related to #4656

Summary

The PR implement prefer-called-exactly-once-with which is a missing recommended vitest rules. The decisions that I took are:

Instead of do as Eslint, multiple iterations over arrays, I'm doing everything in a single pass.
2 diagnostics per target detected that pass our requirements:
- 1 diagnostic for the substitution
- 1 diagnostic for the deletion of the second expect.
The fix is set as dangerous, because one fix means delete the second statement.

Questions

Should do we add a should_run to run this rule only on test files or not? Only if it's possible.

codspeed-hq · 2026-01-01T16:23:22Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

_{Comparing Afsoon:prefer-called-exactly-once-with (6628bcc) with main (e80c0bf)}

52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Afsoon · 2026-01-06T12:54:19Z

Conflicts resolved

Afsoon · 2026-01-21T11:42:23Z

gentle ping @camc314 rebase the branch to sync with the changes in #18076

…sts. Missing nested block statements of test and related methods

…ing against strings

…line of code to his own function

…heck to outer and deleted the duplication of logic

… time.

… removing code.

…cs, one stating the replacing value and the other one the deletion. The fixes are isolated per diagnostic. Using the default help text

…nction

…ostics and method to extract matcher and identefier name.

Afsoon · 2026-03-27T07:48:10Z

gentle ping @camc314, rebased with the last changes in main

camc314

Thank yuo!

# Oxlint ### 💥 BREAKING CHANGES - c0ebbce linter: [**BREAKING**] Report error on unknown builtin rule (#20464) (camc314) ### 🚀 Features - 04f85e5 linter/no-unused-vars: Add safe-fix option for import fixes (#20839) (Marcell Toth) - 32a3706 linter/eslint-vitest-plugin: Implements `require-test-timeout` rule (#20806) (Said Atrahouch) - ae03653 linter: Implement suggestion for `eslint/no-useless-computed-key` rule (#20805) (Mikhail Baev) - 6624513 linter/prefer-string-starts-ends-with: Move rule from nursery to style (#20797) (camc314) - 58941f8 linter/prefer-readonly: Move rule from nursery to style (#20796) (camc314) - 8837ffd linter/prefer-regexp-exec: Move rule from nursery to style (#20795) (camc314) - 7e88871 linter/prefer-find: Move rule out of nursery (#20794) (camc314) - ca6e5bc linter/vitest: Implement prefer-called-exactly-once-with (#17562) (Said Atrahouch) - e80c0bf linter/eslint-plugin-vitest: Implement `require-mock-type-parameters` (#20785) (Said Atrahouch) - cec8b8f linter/vitest: Implement require-awaited-expect-poll rule (#20702) (Said Atrahouch) - d8e9d01 linter/eslint-plugin-vitest: Set `prefer-to-have-been-called-times` compatible with jest (#20703) (Said Atrahouch) - caf8231 linter: Enhance import plugin diagnostics with help messages (#20766) (离谱) - f44adfa linter: Improve the oxlint config generated by `--init`. (#20632) (connorshea) - 43f4827 linter: Add help text to jest and promise diagnostics (#20640) (kszongic) - 16516de linter: Enhance types for `DummyRule` (#20751) (camc314) - 27374e8 linter: Add hint about node version when ts config fail to import (#20570) (camc314) - 8e34150 linter/eslint-plugin-vitest: Sync rule with JS implementation (#20679) (Said Atrahouch) ### 🐛 Bug Fixes - df057d5 linter/no-noninteractive-tabindex: Add missing composite widget … (#20860) (bab) - bb34073 linter: Mark vitest/valid-title as a compatible jest rules (#20463) (Nicolas Le Cam) - bd2c76b linter: Handle shadowed locals in no-restricted-globals (#20811) (Ulrich Stark) - 62e39be linter: Sort nested object keys in fix of `eslint/sort-keys` in one pass (#20838) (Ulrich Stark) - 3ef37da oxlint/lsp: Error on unknown command (#20841) (Sysix) - ab1070d oxlint/cli: Skip parsing base config again for nested config search (#20809) (Sysix) - 2be3728 oxlint/lsp: Skip parsing base config again for nested config search (#20808) (Sysix) - 6171217 oxlint: Respect `NO_COLOR` env for `format=stylish` (#20804) (Sysix) - d89ae8f linter/plugins: Patch `WeakMap` to emulate `WeakMap`s keyed by `sourceCode` (#20799) (overlookmotel) - c610666 linter/no-shadow: Respect env settings when builtinGlobals is enabled (#20429) (vvnikita74) - 6bb502f linter/no-invalid-void-type: Allow void generic args in heritage clauses (#20780) (camc314) - 365bb7d linter: Skip typed nested literals in explicit-module-boundary-types (#20776) (camc314) - 0aa1ff0 linter/plugins: Ensure `after` hook is always called in ESLint compat mode (#20721) (overlookmotel) - 31145a9 linter/plugins: Fire `after` hook after CFG events in ESLint compat (#20720) (overlookmotel) - c09a5ab diagnostics: Skip minified fallback for single-line reporters (#20716) (camc314) - e4dc9a1 linter: Isolate `--init` config writes from parallel tests (#20717) (camc314) - 7e394ec linter: Clarify empty replacement fixer help text (#20698) (camc314) - d15a99c linter/jsx-curly-brace-presence: Flag empty string literals (#20690) (camc314) ### 📚 Documentation - c722495 linter: Update JS Plugins + LS references (#20843) (camc314) - e1f9748 linter/jsdoc/require-property: Fix typo (#20792) (Benjaming61001) - be3dcc1 linter: Add note about node version + custom TS plugin (#19381) (camc314) # Oxfmt ### 🚀 Features - 6ef440a oxfmt: Support bool for object style options (#20853) (leaysgur) - 23050fa oxfmt: Support markdown-in-js substitution (#20683) (leaysgur) - 4087295 oxfmt: Support angular-in-js substitution (#20676) (leaysgur)

Afsoon requested a review from camc314 as a code owner January 1, 2026 16:17

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jan 1, 2026

camc314 changed the title ~~feat(linter/eslint-plugin-vitest): Implement prefer-called-exactly-once-with~~ feat(linter/eslint-plugin-vitest): implement prefer-called-exactly-once-with Jan 1, 2026

camc314 self-assigned this Jan 2, 2026

Afsoon force-pushed the prefer-called-exactly-once-with branch from a381eae to d392f84 Compare January 6, 2026 12:53

Afsoon force-pushed the prefer-called-exactly-once-with branch 3 times, most recently from bdcf7a7 to f609d86 Compare January 13, 2026 06:35

Afsoon force-pushed the prefer-called-exactly-once-with branch 2 times, most recently from 144c32f to 6d7e89d Compare January 21, 2026 11:39

Afsoon force-pushed the prefer-called-exactly-once-with branch from 6d7e89d to a4aad15 Compare February 6, 2026 07:31

camc314 force-pushed the prefer-called-exactly-once-with branch from a4aad15 to e12cee6 Compare February 19, 2026 17:23

camc314 changed the title ~~feat(linter/eslint-plugin-vitest): implement prefer-called-exactly-once-with~~ feat(linter): implement eslint-plugin-vitest/prefer-called-exactly-once-with Feb 19, 2026

Afsoon added 13 commits March 27, 2026 08:45

feat(linter/eslint-plugin-vitest): not error pass test

a04caed

feat(linter/eslint-plugin-vitest): handle most of the fail and fix te…

dd7787b

…sts. Missing nested block statements of test and related methods

feat(linter/eslint-plugin-vitest): handle test blockstatements

3ddcd50

feat(linter/eslint-plugin-vitest): Added MatcherKind instead of match…

e8ba976

…ing against strings

feat(linter/eslint-plugin-vitest): Refactor detect the column 0 of a …

78ecc33

…line of code to his own function

feat(linter/eslint-plugin-vitest): Moved the nested mock reset call c…

76add12

…heck to outer and deleted the duplication of logic

feat(linter/eslint-plugin-vitest): Set capacity to fxhashset ahead of…

385d348

… time.

feat(linter/eslint-plugin-vitest): is_not_modifier_member name

cfc33a5

feat(linter/eslint-plugin-vitest): Set the fix as dangerous as we are…

d9a780c

… removing code.

feat(linter/eslint-plugin-vitest): Displaying two different diagnosti…

696c41f

…cs, one stating the replacing value and the other one the deletion. The fixes are isolated per diagnostic. Using the default help text

feat(linter/eslint-plugin-vitest): parse call expression statement fu…

080cf7c

…nction

feat(linter/eslint-plugin-vitest): More detailed documentation, diagn…

0672c9b

…ostics and method to extract matcher and identefier name.

feat(linter/eslint-plugin-vitest): Cleared clippy warning

7c6ff7c

camc314 added 8 commits March 27, 2026 08:45

simplify

735e36c

u

82d626b

u

47f91de

u

496648f

u

cefb538

u

112dc16

u

6917951

conflict

babcab3

Afsoon force-pushed the prefer-called-exactly-once-with branch from 03b5c85 to babcab3 Compare March 27, 2026 07:45

camc314 approved these changes Mar 27, 2026

View reviewed changes

Merge branch 'main' into prefer-called-exactly-once-with

6628bcc

camc314 merged commit ca6e5bc into oxc-project:main Mar 27, 2026
25 checks passed

Boshen mentioned this pull request Mar 30, 2026

release(apps): oxlint v1.58.0 && oxfmt v0.43.0 #20867

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): implement eslint-plugin-vitest/prefer-called-exactly-once-with#17562

feat(linter): implement eslint-plugin-vitest/prefer-called-exactly-once-with#17562
camc314 merged 22 commits intooxc-project:mainfrom
Afsoon:prefer-called-exactly-once-with

Afsoon commented Jan 1, 2026

Uh oh!

codspeed-hq bot commented Jan 1, 2026 •

edited

Loading

Uh oh!

Afsoon commented Jan 6, 2026

Uh oh!

Afsoon commented Jan 21, 2026

Uh oh!

Afsoon commented Mar 27, 2026 •

edited

Loading

Uh oh!

camc314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Afsoon commented Jan 1, 2026

Summary

Questions

Uh oh!

codspeed-hq bot commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Afsoon commented Jan 6, 2026

Uh oh!

Afsoon commented Jan 21, 2026

Uh oh!

Afsoon commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Jan 1, 2026 •

edited

Loading

Afsoon commented Mar 27, 2026 •

edited

Loading