fix(oxlint): v1.36.0 file discovery regression by hirehamir · Pull Request #17513 · oxc-project/oxc

hirehamir · 2025-12-30T21:41:42Z

Copilot

Pull request overview

This PR fixes a file discovery regression introduced in v1.36.0 where oxlint would find 0 files when walking subdirectories. The root cause was the .require_git(false) configuration, which caused the walker to traverse upward and apply parent directory .gitignore patterns (like /*.js) incorrectly to subdirectory files.

Key changes:

Removed .require_git(false) from the walker configuration to prevent upward traversal and incorrect application of parent .gitignore patterns
Changed .git_ignore(true) to .git_ignore(!options.no_ignore) to make git ignore behavior consistent with the --no-ignore CLI option
Added regression test to verify subdirectory file discovery works correctly
Marked previous test for .require_git(false) functionality as ignored, with explanation of why the feature was disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

connorshea · 2025-12-30T22:07:53Z

+        // This test must run from within the oxc repo to reproduce the bug, since it relies
+        // on finding the real .gitignore in the parent directory structure.


Hmm, do we have a way to reproduce this bug that doesn't rely on the gitignore at the root of the repo? It'd be goofy to change that and break tests.

That's a fair point. I'll see if I can push up something to address this shortly.

camc314 · 2025-12-30T22:20:59Z

i don't understand how this fixes the isssue? what's the root cause?

camc314

this doesn't feel like a proper fix - can you explain the setup with your gitignore files and why you've got them if you're not inside a git repo?

hirehamir · 2025-12-30T22:51:10Z

this doesn't feel like a proper fix - can you explain the setup with your gitignore files and why you've got them if you're not inside a git repo?

Sure. I might have a different setup than some people. I have a .gitignore file in my home directory that ignores everything, and then adds back specific files, like

.bashrc

Then, in my home directory, I have different Git repositories with their own

.gitignore

files. It was in one of these Git repositories in my home directory that the original issue occurred.

hirehamir · 2025-12-30T22:52:42Z

Hope this helps:

/home/hamir/
  .gitignore      ← Contains * to ignore everything, and then !.bashrc
  .git/           ← Home is a Git repo for dotfile management
  my-project/     ← My project (nested inside home dir) where
    .git/           `npx oxlint .` incorrectly runs on 0 files with v1.36.0
    src/             but not v1.35.0
      file.ts

connorshea · 2025-12-30T22:57:28Z

Hmm, if we can't easily fix this by ignoring .gitignore files outside the current project (since there's not really any way to determine what "outside" is if there's no git repo. Unless we assume the cwd is the root of the project?), should we just straight-up error out if the user doesn't have a git repo initialized?

hirehamir · 2025-12-31T18:28:41Z

I think this is what was happening...

With .require_git(false) (buggy v1.36.0):

Walker starts at my-project/
Traverses past my-project/.git/ (ignores Git boundaries)
Finds .gitignore with * pattern
Filters out everything
Result: 0 files ❌

Without .require_git(false) (this fix):

Walker starts at my-project/
Looks for .git going upward
Finds my-project/.git/ and stops there (respects Git boundary)
Only uses .gitignore files within my-project/
Never looks at ~/.gitignore
Result: Files found correctly ✅

camc314 · 2026-01-08T23:03:14Z

@hamirmahal can you try #17813 and see if that fixes your issue? thanks

hirehamir · 2026-01-09T04:59:04Z

You're welcome, and thanks for looking into this. I think the approach that's there right now fixes things.

hirehamir · 2026-01-09T04:59:13Z

$ git branch && cargo run --bin oxlint ~/test/
  c/01-08-fix_linter_skip_looking_for_ignore_files_in_parent_directories
* main
   Compiling oxlint v1.38.0 (/home/hamir/oxc/apps/oxlint)
    Finished `dev` profile [unoptimized] target(s) in 8.23s
     Running `target/debug/oxlint /home/hamir/test/`
Found 0 warnings and 0 errors.
Finished in 16ms on 0 files with 90 rules using 8 threads.

$ git branch && cargo run --bin oxlint ~/test/
* c/01-08-fix_linter_skip_looking_for_ignore_files_in_parent_directories
  main
   Compiling oxlint v1.38.0 (/home/hamir/oxc/apps/oxlint)
    Finished `dev` profile [unoptimized] target(s) in 8.10s
     Running `target/debug/oxlint /home/hamir/test/`

  × eslint(no-unused-vars): Variable 'testArray' is declared but never used. Unused variables should start with a '_'.
   ╭─[/home/hamir/test/src/test.ts:1:7]
 1 │ const testArray = []
   ·       ────┬────
   ·           ╰── 'testArray' is declared here
   ╰────
  help: Consider removing this declaration.

Found 0 warnings and 1 error.
Finished in 22ms on 1 file with 90 rules using 8 threads.

hirehamir · 2026-02-28T22:30:31Z

@camc314 I think #17813 seemed to work the last time I tried it, do you want me to check it again?

camc314 · 2026-05-02T17:05:00Z

massive apologies for the delay on this, but thank you for submitting this PR!

I think i've fixed this in a slightly more ideal way, in #22033, that maintains the previous behaviour, while allowiing .gitignores in non-git initialized directories.

The fix should be released on Monday (May 4th) (or possibly tuesday due to the holiday) - please try it and let me know!

Thanks!

hirehamir requested a review from camc314 as a code owner December 30, 2025 21:41

Copilot AI review requested due to automatic review settings December 30, 2025 21:41

github-actions Bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Dec 30, 2025

Copilot started reviewing on behalf of hirehamir December 30, 2025 21:42 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

Comment thread apps/oxlint/src/walk.rs Outdated

Comment thread apps/oxlint/src/walk.rs Outdated

Comment thread apps/oxlint/src/walk.rs Outdated

hirehamir force-pushed the fix/v1.36.0-oxlint-file-discovery-regression branch from 9dee628 to 7b1b62c Compare December 30, 2025 21:51

hirehamir requested a review from Copilot December 30, 2025 21:55

Copilot started reviewing on behalf of hirehamir December 30, 2025 21:55 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

connorshea reviewed Dec 30, 2025

View reviewed changes

fix(oxlint): v1.36.0 file discovery regression

276d984

hirehamir force-pushed the fix/v1.36.0-oxlint-file-discovery-regression branch from 7b1b62c to 276d984 Compare December 30, 2025 22:19

camc314 reviewed Dec 30, 2025

View reviewed changes

camc314 self-assigned this Dec 31, 2025

camc314 mentioned this pull request Jan 8, 2026

fix(linter): skip looking for ignore files in parent directories #17813

Closed

kennyheard mentioned this pull request Apr 3, 2026

linter: File walker applies .gitignore rules from parent directories above the project's .git root #21007

Closed

camc314 mentioned this pull request May 1, 2026

fix(linter): stop gitignore lookup at repo boundary #22033

Merged

graphite-app Bot closed this in 893e18f May 1, 2026

hirehamir deleted the fix/v1.36.0-oxlint-file-discovery-regression branch May 1, 2026 23:18

Dunqing mentioned this pull request May 7, 2026

fix(codegen): emit call end mapping at ) position, not past it #22199

Merged

3 tasks

		// This test must run from within the oxc repo to reproduce the bug, since it relies
		// on finding the real .gitignore in the parent directory structure.

Uh oh!

Uh oh!

Conversation

hirehamir commented Dec 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

connorshea Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

hirehamir Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

camc314 commented Dec 30, 2025

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

hirehamir commented Dec 30, 2025

Uh oh!

hirehamir commented Dec 30, 2025

Uh oh!

connorshea commented Dec 30, 2025

Uh oh!

hirehamir commented Dec 31, 2025

Uh oh!

camc314 commented Jan 8, 2026

Uh oh!

hirehamir commented Jan 9, 2026

Uh oh!

hirehamir commented Jan 9, 2026

Uh oh!

hirehamir commented Feb 28, 2026

Uh oh!

camc314 commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants