Skip to content

perf(semantic): mark all diagnostic functions as #[cold]#17487

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_
Dec 30, 2025
Merged

perf(semantic): mark all diagnostic functions as #[cold]#17487
graphite-app[bot] merged 1 commit into
mainfrom
c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_

Conversation

@camc314

@camc314 camc314 commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 30, 2025

camc314 commented Dec 30, 2025

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Dec 30, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #17487 will not alter performance

Comparing c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_ (b4e06ba) with c/12-30-perf_transformer_mark_all_diagnostic_functions_as_cold_ (7cb1b92)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314
camc314 force-pushed the c/12-30-perf_transformer_mark_all_diagnostic_functions_as_cold_ branch from fd9e193 to 739d3d5 Compare December 30, 2025 10:57
@camc314
camc314 force-pushed the c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_ branch from bbcb46a to 621b090 Compare December 30, 2025 10:57
@camc314
camc314 marked this pull request as ready for review December 30, 2025 10:58
@camc314
camc314 requested a review from Dunqing as a code owner December 30, 2025 10:58
@camc314
camc314 force-pushed the c/12-30-perf_transformer_mark_all_diagnostic_functions_as_cold_ branch from 739d3d5 to 7cb1b92 Compare December 30, 2025 10:59
@camc314
camc314 force-pushed the c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_ branch from eb76088 to b4e06ba Compare December 30, 2025 10:59
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 30, 2025

Boshen commented Dec 30, 2025

Copy link
Copy Markdown
Member

Merge activity

@graphite-app
graphite-app Bot force-pushed the c/12-30-perf_transformer_mark_all_diagnostic_functions_as_cold_ branch from 7cb1b92 to ea82b50 Compare December 30, 2025 11:40
@graphite-app
graphite-app Bot force-pushed the c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_ branch from b4e06ba to 49ad2f0 Compare December 30, 2025 11:41
Base automatically changed from c/12-30-perf_transformer_mark_all_diagnostic_functions_as_cold_ to main December 30, 2025 11:46
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Dec 30, 2025
@graphite-app
graphite-app Bot merged commit 49ad2f0 into main Dec 30, 2025
21 checks passed
@graphite-app
graphite-app Bot deleted the c/12-30-perf_semantic_mark_all_diagnostic_functions_as_cold_ branch December 30, 2025 11:47
graphite-app Bot pushed a commit that referenced this pull request Jan 5, 2026
### 🚀 Features

- 659c23e linter: Init note field boilerplate  (#17589) (Shrey Sudhir)
- 6870b64 parser: Add TS1363 error code (#17609) (Sysix)
- 23680a3 mangler: Skip mangling only in scopes affected by direct eval (#17612) (camc314)
- a7e1643 parser: Add TS2528 error code to duplicate_default_export diagnostic (#17558) (camc314)

### 🐛 Bug Fixes

- 1044116 ecmascript: Mark `new Symbol` as non side-effect free (#17568) (camc314)
- ab5e4ca isolated-declarations: Strip default values from rest parameter binding patterns (#17602) (camc314)
- 68b2e54 minifier: Prevent incorrect ??= transformation when member base is mutated (#17472) (copilot-swe-agent)

### ⚡ Performance

- 6067143 semantic: Remove hash when checking identifier (#17564) (camchenry)
- a28ab3d semantic: Avoid bounds check when checking string literal (#17545) (camc314)
- 04809d1 semantic: Use SIMD for finding backslashes in `check_string_literal` (#17534) (camchenry)
- 49ad2f0 semantic: Mark all diagnostic functions as `#[cold]` (#17487) (camc314)
- ea82b50 transformer: Mark all diagnostic functions as `#[cold]` (#17486) (camc314)
- d968e51 semantic: Mark `checker::check` as `inline(always)` (#17459) (camc314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants