Skip to content

feat(oxfmt): Respect single nearest .editorconfig#17043

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-18-feat_oxfmt_respect_single_nearest_.editorconfig
Dec 18, 2025
Merged

feat(oxfmt): Respect single nearest .editorconfig#17043
graphite-app[bot] merged 1 commit intomainfrom
12-18-feat_oxfmt_respect_single_nearest_.editorconfig

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 18, 2025

Part of #15850

  • Support single nearest .editorconfig
    • It may be different directory vs .oxfmtrc
    • root is just ignored
  • Always apply [*] settings if exists
  • If per-file overrides are written, try to resolve it before formatting on each file
    • If tried, but it was the same with [*], fallback to cached fast path
  • Only 4 properties are applied for now
    • end_of_line, indent_style, indent_size, max_line_length(value only)
    • Same as Prettier

Will add tests in next PR.

Copy link
Member Author

leaysgur commented Dec 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #17043 will not alter performance

Comparing 12-18-feat_oxfmt_respect_single_nearest_.editorconfig (be1da2e) with main (3d2b492)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on 12-18-refacotr_oxfmt_clean_up_src-js_files (84aac2a) during the generation of this report, so main (3d2b492) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch 2 times, most recently from 85cb39e to f8f32f3 Compare December 18, 2025 06:18
@leaysgur leaysgur changed the title feat(oxfmt): Respect single nearest .editorconfig feat(oxfmt): Respect single nearest .editorconfig Dec 18, 2025
@leaysgur leaysgur force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from f8f32f3 to 6f49f6a Compare December 18, 2025 06:43
@leaysgur leaysgur marked this pull request as ready for review December 18, 2025 06:57
@leaysgur leaysgur requested a review from Dunqing December 18, 2025 06:57
@leaysgur leaysgur force-pushed the 12-18-refacotr_oxfmt_clean_up_src-js_files branch from 4db40e7 to 84aac2a Compare December 18, 2025 07:55
@leaysgur leaysgur force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from 6f49f6a to be1da2e Compare December 18, 2025 07:55
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 18, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-18-refacotr_oxfmt_clean_up_src-js_files branch from 84aac2a to d20911c Compare December 18, 2025 10:41
graphite-app bot pushed a commit that referenced this pull request Dec 18, 2025
Part of #15850

- Support single nearest `.editorconfig`
  - It may be different directory vs `.oxfmtrc`
  - `root` is just ignored
- Always apply `[*]` settings if exists
- If per-file overrides are written, try to resolve it before formatting on each file
  - If tried, but it was the same with `[*]`, fallback to cached fast path
- Only 4 properties are applied for now
  - end_of_line, indent_style, indent_size, max_line_length(value only)
  - Same as Prettier

Will add tests in next PR.
@graphite-app graphite-app bot force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from be1da2e to 06b3434 Compare December 18, 2025 10:42
Part of #15850

- Support single nearest `.editorconfig`
  - It may be different directory vs `.oxfmtrc`
  - `root` is just ignored
- Always apply `[*]` settings if exists
- If per-file overrides are written, try to resolve it before formatting on each file
  - If tried, but it was the same with `[*]`, fallback to cached fast path
- Only 4 properties are applied for now
  - end_of_line, indent_style, indent_size, max_line_length(value only)
  - Same as Prettier

Will add tests in next PR.
@graphite-app graphite-app bot force-pushed the 12-18-refacotr_oxfmt_clean_up_src-js_files branch from d20911c to b4e8605 Compare December 18, 2025 10:45
@graphite-app graphite-app bot force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from 06b3434 to 15dfb55 Compare December 18, 2025 10:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 18, 2025
Base automatically changed from 12-18-refacotr_oxfmt_clean_up_src-js_files to main December 18, 2025 10:54
@graphite-app graphite-app bot merged commit 15dfb55 into main Dec 18, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch December 18, 2025 10:54
overlookmotel added a commit that referenced this pull request Dec 19, 2025
# Oxlint
### 🚀 Features

- 6cc3fdf linter/no-inferrable-types: Implement fixer (#17090) (camc314)
- 2067997 linter/no-negation-in-equality-check: Implement suggestion
(#17084) (camc314)
- 552f9ef vscode: Auto-generate VSCode README configuration from
package.json (#16970) (Copilot)
- 9190c4b linter/no-unnecessary-array-flat-depth: Implement fixer
(#17057) (camc314)
- ed789de linter/misrefactored-assign-op: Implement fixer (#17056)
(camc314)
- a0f74a0 linter/config: Allow aliasing plugin names to allow names the
same as builtin plugins (#15569) (Cameron)
- a43d251 linter/plugins: `RuleTester` support `languageOptions.globals`
(#17009) (overlookmotel)
- 35070d9 linter/bad-bitwise-operator: Implement fixer (#17006)
(camc314)
- 322d995 linter/prefer-enum-initializers: Implement fixer (#17004)
(camc314)
- ae1e5bc vscode: Add support for tsgolint binary configuration (#16921)
(ColemanDunn)
- 3bfe31e linter/eslint-plugin-vitest: Add prefer-called-with as vitest
compatible jest rule (#16993) (Said Atrahouch)
- 0cd075f linter/eslint-plugin-jest: Add fix capabilities to
prefer-called-with rule (#16987) (Said Atrahouch)
- 357564b linter: Add options for
`typescript/require-array-sort-compare` rule. (#16980) (connorshea)
- 2b0ffba linter: Add options for
`typescript/no-meaningless-void-operator` rule. (#16981) (connorshea)
- 8bc4287 linter/plugins: Validate options against schema (#16974)
(overlookmotel)
- fdc7d08 linter: Implement eslint/capitalized-comments (#16896) (Tu
Shaokun)
- f8b6561 linter: Add support for `test.for` in vitest (#16925)
(camchenry)
- 7ee0379 linter/eslint-plugin-vitest: Implement prefer-spy-on (#16426)
(Said Atrahouch)
- fc96ee0 linter: Implement jest/prefer-to-have-been-called-times
(#16938) (秦宇航)
- 291b57b ast_tools: Generate TS declaration files for deserializer and
walk files (#16912) (camc314)
- e31da2a linter: Implement jest/perfer-to-have-been-called (#16899)
(秦宇航)
- 1a31306 linter/eslint-plugin-vitest: Add require-hook as vitest
compatible jest rule (#16880) (Said Atrahouch)
- cd3db21 linter: Add ignoredTypeNames option to no-base-to-string rule
(#16898) (camc314)
- 763b25a linter: Implement eslint/no-inline-comments (#16885) (Tu
Shaokun)

### 🐛 Bug Fixes

- fb9e193 linter: OOM problems with custom plugins (#17082)
(overlookmotel)
- 005ec25 linter: Permit `$schema` `.oxlintrc.json` struct (#17060)
(Copilot)
- fd03131 linter/plugins: Handle plugin names containing slashes
(#17073) (overlookmotel)
- b2a4fac linter/plugins: Error if plugin name alias is not normalized
(#17071) (overlookmotel)
- e046c4e linter/no-misused-spread: Add rule options support (#17054)
(camc314)
- 5c1a9e0 linter/no-deprecated: Add rule options support (#17053)
(camc314)
- 8c9cafe linter: `import/consistent-type-specifier-style`: add support
for declaration files (#16979) (camchenry)
- dab4780 linter/no-empty-pattern: Misleading help message for arrays
(#17039) (Copilot)
- 67f8c5d linter/plugins: Get correct plugin name in all cases (#17033)
(overlookmotel)
- 674dab9 linter/plugins: Fix indentation in error message (#17018)
(overlookmotel)
- 6524f72 linter/plugins: Add `@types/node` dev dependency to `oxlint`
package (#17016) (overlookmotel)
- 7a35513 linter/plugins: Better error for `null` in `globals` in
`RuleTester` (#17011) (overlookmotel)
- 42603ba linter/plugins: Always define `languageOptions.globals`
(#17008) (overlookmotel)
- 4cdc2f8 linter: Fix VITEST override rule list and add test for
alphabetizing the two lists (#16975) (Connor Shea)
- e466562 linter/consistent-type-definitions: Handle parenthesized types
in rule (#16998) (camc314)
- fce267c linter: Correct vitest plugin source to be
`@vitest/eslint-plugin` (#16976) (connorshea)
- 477bb57 linter: Fix `vitest/no-restricted-vi-methods` and add tests
for it. (#16971) (connorshea)
- 7d6974d linter: Ignore oxlint directive comments in
capitalized-comments (#16989) (Tu Shaokun)
- 23ac6b1 linter/plugins: Apply defaults from `meta.schema` to options
(#16930) (overlookmotel)
- 2f946cf linter/plugins: Error if `defaultOptions` is not
JSON-serializable (#16959) (overlookmotel)
- d8b8a57 linter/plugins: Freeze whole of merged options (#16958)
(overlookmotel)
- d446c43 linter: Prevent extra fields from being present on oxlint
config file (#16874) (connorshea)
- b845871 linter/plugins: Correctly handle object with `__proto__` keys
in options merging (#16928) (overlookmotel)
- c897794 linter: Fix eslint/sort-imports allowSeparatedGroups not
working with single empty line (#16012) (Duc Nghiem Xuan)
- 0c347a1 linter/array-type: Handle satisfies expression (#16903)
(camc314)

### ⚡ Performance

- 70d853c linter: Avoid cloning source text when cloning AST into
fixed-size allocator (#17088) (overlookmotel)
- 4d389f7 linter: Less bounds checks in `normalize_plugin_name` (#17030)
(overlookmotel)
- fd8e9c6 linter/plugins: Speed up cloning JSON objects (#16997)
(overlookmotel)
- d77e22d linter/plugins: Use `DEFAULT_OPTIONS` for rules with empty
array as default options (#16913) (overlookmotel)

### 📚 Documentation

- 6d053b4 linter: Fix typo in doc comment (#17091) (overlookmotel)
- b5f3c91 linter: Document intentional exclusion of ignoreCase option in
jsx-no-duplicate-props (#17046) (Copilot)
- a0bf5d8 linter: Fix the config option docs for no-inline-comments
rule. (#16983) (connorshea)
- ca26a11 linter/plugins: Fix typo in doc comment (#16966)
(overlookmotel)
- 3183bf8 linter/plugins: Fix typo in JSDoc comment (#16900)
(overlookmotel)
# Oxfmt
### 🚀 Features

- 15dfb55 oxfmt: Respect single nearest `.editorconfig` (#17043)
(leaysgur)
- 8c33ff4 oxfmt: Expose Node.js API: `format(fileName, sourceText,
options?)` (#16939) (leaysgur)

### 🐛 Bug Fixes

- d340c87 oxfmt: Update api `FormatOptions` type with `& Record<string,
unknown>` (#17036) (leaysgur)
- 827a256 oxfmt: Place ignorePatterns at bottom of JSON in --migrate
prettier (#16926) (Boshen)

Co-authored-by: overlookmotel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments