fix(tools): fix type-checking in Oxlint plugin#17015
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 17, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript type-checking for the Oxlint JS plugin by adding proper TypeScript configuration to the plugins directory. The plugin file is renamed from .mts to .ts since it no longer needs the .mts extension outside the repository root.
- Added
tsconfig.jsontopluginsdirectory with appropriate compiler options for ESNext module resolution - Updated
package.jsoninpluginsdirectory with required dependencies and metadata - Renamed plugin file from
oxlint-plugin.mtstooxlint-plugin.ts
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/tsconfig.json | Adds TypeScript configuration with module preservation, bundler resolution, and strict type checking options |
| plugins/package.json | Adds package metadata including @types/node dependency, marks as private, sets module type, and defines Node.js engine requirement |
| plugins/oxlint-plugin.ts | Plugin implementation file renamed from .mts to .ts extension |
| oxlintrc.json | Updates jsPlugins path reference from ./plugins/oxlint-plugin.mts to ./plugins/oxlint-plugin.ts |
| pnpm-lock.yaml | Adds @types/[email protected] dependency for the plugins package |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
#16982 moved the Oxlint JS plugin that we use for linting this repo into `plugins` directory. Add a `tsconfig.json` file to this directly so TS understands it. Also rename the plugin file to `.ts` - it only had to be `.mts` previously because it was in root of the repo.
graphite-app
bot
force-pushed
the
12-17-fix_tools_fix_type-checking_in_oxlint_plugin
branch
from
f8f7521 to
04e1458
Compare
graphite-app
bot
deleted the
12-17-fix_tools_fix_type-checking_in_oxlint_plugin
branch
camc314
reviewed
Dec 17, 2025
qinyuhang
pushed a commit
to qinyuhang/oxc
that referenced
this pull request
Jan 22, 2026
oxc-project#16982 moved the Oxlint JS plugin that we use for linting this repo into `plugins` directory. Add a `tsconfig.json` file to this directly so TS understands it. Also rename the plugin file to `.ts` - it only had to be `.mts` previously because it was in root of the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16982 moved the Oxlint JS plugin that we use for linting this repo into
pluginsdirectory.Add a
tsconfig.jsonfile to this directly so TS understands it. Also rename the plugin file to.ts- it only had to be.mtspreviously because it was in root of the repo.