refactor(linter/plugins): introduce methods for deep cloning JSON values by overlookmotel · Pull Request #16962 · oxc-project/oxc

overlookmotel · 2025-12-16T15:54:22Z

Add methods for deep cloning JSON values, objects, and arrays. These are used in the next PR (#16930).

overlookmotel · 2025-12-16T15:54:44Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR introduces deep cloning functionality for JSON values, complementing the existing deep freeze utilities. The implementation adds three new functions that handle recursive cloning of JSON objects, arrays, and primitive values.

Key changes:

Added deepCloneJsonValue as the main entry point for cloning any JSON value
Implemented deepCloneJsonObject and deepCloneJsonArray for recursive cloning of complex types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/oxlint/src-js/plugins/json.ts

nrayburn-tech · 2025-12-16T22:12:29Z

No idea of perf, but was https://developer.mozilla.org/en-US/docs/Web/API/Window/structuredClone considered?

overlookmotel · 2025-12-16T23:00:59Z

Thanks for your comment. I hadn't thought of that.

I don't know for sure either, but I imagine the manual implementation is probably faster, as JSON objects are much more constrained (simple) than what you can pass to structuredClone.

This isn't on a hot path, so not so important for perf. So I hope you'll forgive me if I just go with it as is.

graphite-app · 2025-12-16T23:03:14Z

Merge activity

Dec 16, 11:03 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Dec 16, 11:09 PM UTC: Merged by the Graphite merge queue.

…ues (#16962) Add methods for deep cloning JSON values, objects, and arrays. These are used in the next PR (#16930).

camc314 · 2025-12-17T09:34:41Z

strucutredClone is really slow. 😓

https://benchmarklab.azurewebsites.net/Benchmarks/Show/31723/0/json-parse-vs-structuredclone-bigger-object

Not sure of the perf diff vs this implementation

overlookmotel · 2025-12-17T10:27:08Z

Interesting. I added the manual clone impl from this PR to the benchmark. It's much faster.

https://benchmarklab.azurewebsites.net/Benchmarks/ShowResult/622555

Follow-on after #16962. Small optimization to `deepCloneJsonObject`. Iterate through keys of `cloned` instead of `obj`. Benchmark shows this is marginally faster (0.3%): https://benchmarklab.azurewebsites.net/Benchmarks/ShowResult/622556

…ues (oxc-project#16962) Add methods for deep cloning JSON values, objects, and arrays. These are used in the next PR (oxc-project#16930).

Follow-on after oxc-project#16962. Small optimization to `deepCloneJsonObject`. Iterate through keys of `cloned` instead of `obj`. Benchmark shows this is marginally faster (0.3%): https://benchmarklab.azurewebsites.net/Benchmarks/ShowResult/622556

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 16, 2025

This was referenced Dec 16, 2025

fix(linter/plugins): apply defaults from meta.schema to options #16930

Merged

fix(linter/plugins): freeze whole of merged options #16958

Merged

fix(linter/plugins): error if defaultOptions is not JSON-serializable #16959

Merged

This was referenced Dec 16, 2025

refactor(linter/plugins): simplify binding it.only in RuleTester #16960

Merged

refactor(linter/plugins): convert global properties to vars with TSDown plugin, instead of manually #16961

Merged

overlookmotel marked this pull request as ready for review December 16, 2025 16:07

overlookmotel requested a review from camc314 as a code owner December 16, 2025 16:07

Copilot AI review requested due to automatic review settings December 16, 2025 16:07

Copilot AI reviewed Dec 16, 2025

View reviewed changes

apps/oxlint/src-js/plugins/json.ts Outdated Show resolved Hide resolved

overlookmotel self-assigned this Dec 16, 2025

overlookmotel force-pushed the 12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values branch from dfb2fbc to 2763b8f Compare December 16, 2025 16:27

overlookmotel force-pushed the 12-16-refactor_linter_plugins_convert_global_properties_to_vars_with_tsdown_plugin_instead_of_manually branch from 1abbb33 to 1351d60 Compare December 16, 2025 16:27

graphite-app bot force-pushed the 12-16-refactor_linter_plugins_convert_global_properties_to_vars_with_tsdown_plugin_instead_of_manually branch 2 times, most recently from 1a6536f to d827a4a Compare December 16, 2025 16:46

graphite-app bot force-pushed the 12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values branch from 2763b8f to 220c326 Compare December 16, 2025 16:47

graphite-app bot changed the base branch from 12-16-refactor_linter_plugins_convert_global_properties_to_vars_with_tsdown_plugin_instead_of_manually to graphite-base/16962 December 16, 2025 17:33

graphite-app bot force-pushed the 12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values branch from 220c326 to b27b3c1 Compare December 16, 2025 17:40

graphite-app bot force-pushed the graphite-base/16962 branch from d827a4a to da509be Compare December 16, 2025 17:40

graphite-app bot changed the base branch from graphite-base/16962 to main December 16, 2025 17:41

graphite-app bot force-pushed the 12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values branch from b27b3c1 to b1a8ac2 Compare December 16, 2025 17:41

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 16, 2025

refactor(linter/plugins): introduce methods for deep cloning JSON val…

4c4de62

…ues (#16962) Add methods for deep cloning JSON values, objects, and arrays. These are used in the next PR (#16930).

graphite-app bot force-pushed the 12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values branch from b1a8ac2 to 4c4de62 Compare December 16, 2025 23:03

graphite-app bot merged commit 4c4de62 into main Dec 16, 2025
18 checks passed

graphite-app bot deleted the 12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values branch December 16, 2025 23:09

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 16, 2025

overlookmotel mentioned this pull request Dec 17, 2025

perf(linter/plugins): speed up cloning JSON objects #16997

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(linter/plugins): introduce methods for deep cloning JSON values#16962

refactor(linter/plugins): introduce methods for deep cloning JSON values#16962
graphite-app[bot] merged 1 commit intomainfrom
12-16-refactor_linter_plugins_introduce_methods_for_deep_cloning_json_values

overlookmotel commented Dec 16, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Dec 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

nrayburn-tech commented Dec 16, 2025

Uh oh!

overlookmotel commented Dec 16, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

camc314 commented Dec 17, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Uh oh!

Conversation

overlookmotel commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

nrayburn-tech commented Dec 16, 2025

Uh oh!

overlookmotel commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

camc314 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

overlookmotel commented Dec 16, 2025 •

edited

Loading

overlookmotel commented Dec 16, 2025 •

edited

Loading

overlookmotel commented Dec 16, 2025 •

edited

Loading

graphite-app bot commented Dec 16, 2025 •

edited

Loading

camc314 commented Dec 17, 2025 •

edited

Loading