refactor(linter/plugins): simplify binding it.only in RuleTester#16960
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 16, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
This was referenced Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the binding of it.only in the RuleTester class by replacing Function.bind.call(it.only, it) with the more straightforward it.only.bind(it). Both approaches achieve the same result, but the refactored version is more idiomatic and readable.
Key changes:
- Simplified the method binding syntax for
it.onlyin two locations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
12-16-refactor_linter_plugins_simplify_binding_it.only_in_ruletester_
branch
from
6a77d23 to
e88c42b
Compare
overlookmotel
force-pushed
the
12-16-fix_linter_plugins_error_if_defaultoptions_is_not_json-serializable
branch
from
c83089a to
be2e431
Compare
Member
Author
Merge activity
|
…16960) Tiny refactor. `Function` does not actually have a property called `bind` - it's on `Function.prototype`.
graphite-app
bot
force-pushed
the
12-16-fix_linter_plugins_error_if_defaultoptions_is_not_json-serializable
branch
from
be2e431 to
2f946cf
Compare
graphite-app
bot
force-pushed
the
12-16-refactor_linter_plugins_simplify_binding_it.only_in_ruletester_
branch
from
e88c42b to
0cbd88c
Compare
Base automatically changed from
12-16-fix_linter_plugins_error_if_defaultoptions_is_not_json-serializable
to
main
December 16, 2025 16:45
graphite-app
bot
deleted the
12-16-refactor_linter_plugins_simplify_binding_it.only_in_ruletester_
branch
qinyuhang
pushed a commit
to qinyuhang/oxc
that referenced
this pull request
Jan 22, 2026
…xc-project#16960) Tiny refactor. `Function` does not actually have a property called `bind` - it's on `Function.prototype`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny refactor.
Functiondoes not actually have a property calledbind- it's onFunction.prototype.