Skip to content

test(regular_expression): add tests for diagnostics#16951

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-16-feat_regular_expression_add_tests_for_diagnostics
Dec 17, 2025
Merged

test(regular_expression): add tests for diagnostics#16951
graphite-app[bot] merged 1 commit intomainfrom
12-16-feat_regular_expression_add_tests_for_diagnostics

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Dec 16, 2025 •
edited
Loading

Added some test cases that covers the diagnostics.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 16, 2025
This was referenced Dec 16, 2025
Merged
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Dec 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 16, 2025
Merged
Merged
Merged
@sapphi-red sapphi-red changed the title feat(regular_expression): add tests for diagnostics test(regular_expression): add tests for diagnostics Dec 16, 2025
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 16, 2025
@sapphi-red sapphi-red added A-regular-expression Area - Regular Expression and removed C-enhancement Category - New feature or request labels Dec 16, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16951 will not alter performance

Comparing 12-16-feat_regular_expression_add_tests_for_diagnostics (5ba0d9e) with main (fc96ee0)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (7617327) during the generation of this report, so fc96ee0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sapphi-red sapphi-red force-pushed the 12-16-feat_regular_expression_add_tests_for_diagnostics branch from b761bde to ca71b52 Compare December 16, 2025 11:27
@graphite-app graphite-app bot changed the base branch from 12-16-feat_parser_improve_error_message_for_yield_as_identifier_usage to graphite-base/16951 December 16, 2025 11:31
@graphite-app graphite-app bot force-pushed the 12-16-feat_regular_expression_add_tests_for_diagnostics branch from ca71b52 to c693dca Compare December 16, 2025 11:38
@graphite-app graphite-app bot force-pushed the graphite-base/16951 branch from 8f6b327 to cb515fa Compare December 16, 2025 11:38
@graphite-app graphite-app bot changed the base branch from graphite-base/16951 to main December 16, 2025 11:38
@graphite-app graphite-app bot force-pushed the 12-16-feat_regular_expression_add_tests_for_diagnostics branch from c693dca to 74820a3 Compare December 16, 2025 11:39
@sapphi-red sapphi-red marked this pull request as ready for review December 16, 2025 11:43
@sapphi-red sapphi-red requested a review from leaysgur as a code owner December 16, 2025 11:43
@sapphi-red sapphi-red requested review from Copilot and removed request for Copilot December 16, 2025 11:43
@sapphi-red sapphi-red force-pushed the 12-16-feat_regular_expression_add_tests_for_diagnostics branch from 74820a3 to 5ba0d9e Compare December 16, 2025 12:09
Copilot AI review requested due to automatic review settings December 16, 2025 12:09
Copilot AI reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 17, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 17, 2025 •
edited
Loading

Merge activity

@sapphi-red
test(regular_expression): add tests for diagnostics (#16951)
8d7ee53 
Added some test cases that covers the diagnostics.
@graphite-app graphite-app bot force-pushed the 12-16-feat_regular_expression_add_tests_for_diagnostics branch from 5ba0d9e to 8d7ee53 Compare December 17, 2025 00:38
@graphite-app graphite-app bot merged commit 8d7ee53 into main Dec 17, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-16-feat_regular_expression_add_tests_for_diagnostics branch December 17, 2025 00:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 17, 2025
qinyuhang pushed a commit to qinyuhang/oxc that referenced this pull request Jan 22, 2026
@sapphi-red @qinyuhang
test(regular_expression): add tests for diagnostics (oxc-project#16951)
2f07834 
Added some test cases that covers the diagnostics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@leaysgur leaysgur leaysgur approved these changes

Assignees

@leaysgur leaysgur

Labels

A-regular-expression Area - Regular Expression C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @leaysgur

Comments