Skip to content

Comments

refactor(oxfmt): Align usage of napi::block_on()#16935

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-16-refactor_oxfmt_align_usage_of_napi_block_on
Dec 16, 2025
Merged

refactor(oxfmt): Align usage of napi::block_on()#16935
graphite-app[bot] merged 1 commit intomainfrom
12-16-refactor_oxfmt_align_usage_of_napi_block_on

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 16, 2025

Pure refactoring.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 16, 2025
Copy link
Member Author

leaysgur commented Dec 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title refactor(oxfmt): Align usage of napi::block_on refactor(oxfmt): Align usage of napi::block_on() Dec 16, 2025
@leaysgur leaysgur force-pushed the 12-16-refactor_oxfmt_align_usage_of_napi_block_on branch from e435732 to 34d52b4 Compare December 16, 2025 05:04
@leaysgur leaysgur requested a review from Dunqing December 16, 2025 05:04
@leaysgur leaysgur force-pushed the 12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times branch from 88879d0 to 86589f3 Compare December 16, 2025 06:46
@leaysgur leaysgur force-pushed the 12-16-refactor_oxfmt_align_usage_of_napi_block_on branch from 34d52b4 to 3b4c7ad Compare December 16, 2025 06:46
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 16, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 16, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times branch from 86589f3 to 71ee6e8 Compare December 16, 2025 11:40
@graphite-app graphite-app bot requested review from Sysix and camc314 as code owners December 16, 2025 11:40
graphite-app bot pushed a commit that referenced this pull request Dec 16, 2025
@graphite-app graphite-app bot force-pushed the 12-16-refactor_oxfmt_align_usage_of_napi_block_on branch from 3b4c7ad to a0bb152 Compare December 16, 2025 11:40
Base automatically changed from 12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times to main December 16, 2025 11:48
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Dec 16, 2025
Copilot AI review requested due to automatic review settings December 16, 2025 12:30
@graphite-app graphite-app bot force-pushed the 12-16-refactor_oxfmt_align_usage_of_napi_block_on branch from a0bb152 to 7ca7321 Compare December 16, 2025 12:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 7ca7321 into main Dec 16, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 12-16-refactor_oxfmt_align_usage_of_napi_block_on branch December 16, 2025 12:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 16, 2025
Boshen pushed a commit that referenced this pull request Dec 16, 2025
qinyuhang pushed a commit to qinyuhang/oxc that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants