Skip to content

Comments

refactor(oxfmt): Allow to call setupConfig() multiple times#16934

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times
Dec 16, 2025
Merged

refactor(oxfmt): Allow to call setupConfig() multiple times#16934
graphite-app[bot] merged 1 commit intomainfrom
12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 16, 2025

For exposing the Node.js API's format() method; I did not expect for it being called multiple times, so fix it.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 16, 2025
Copy link
Member Author

leaysgur commented Dec 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title refactor(oxfmt): Allow to call setupConfig multiple times refactor(oxfmt): Allow to call setupConfig() multiple times Dec 16, 2025
@leaysgur leaysgur requested a review from Dunqing December 16, 2025 05:04
@leaysgur leaysgur force-pushed the 12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times branch from 88879d0 to 86589f3 Compare December 16, 2025 06:46
@leaysgur leaysgur force-pushed the 12-16-refactor_formatter_oxfmtrc_fix_up_oxfmtrc.rs branch from 5ed57f9 to 5ea9f08 Compare December 16, 2025 06:46
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 16, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 16, 2025

Merge activity

For exposing the Node.js API's `format()` method; I did not expect for it being called multiple times, so fix it.
@graphite-app graphite-app bot force-pushed the 12-16-refactor_formatter_oxfmtrc_fix_up_oxfmtrc.rs branch from 5ea9f08 to ca28355 Compare December 16, 2025 11:39
@graphite-app graphite-app bot requested review from Sysix and camc314 as code owners December 16, 2025 11:39
@graphite-app graphite-app bot force-pushed the 12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times branch from 86589f3 to 71ee6e8 Compare December 16, 2025 11:40
Base automatically changed from 12-16-refactor_formatter_oxfmtrc_fix_up_oxfmtrc.rs to main December 16, 2025 11:47
@graphite-app graphite-app bot merged commit 71ee6e8 into main Dec 16, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-16-refactor_oxfmt_allow_to_call_setupconfig_multiple_times branch December 16, 2025 11:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 16, 2025
qinyuhang pushed a commit to qinyuhang/oxc that referenced this pull request Jan 22, 2026
…oject#16934)

For exposing the Node.js API's `format()` method; I did not expect for it being called multiple times, so fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants