Skip to content

fix(linter/unicorn/prefer-dom-node-dataset): ignore awaited getAttribute call#16882

Merged
camc314 merged 2 commits intooxc-project:mainfrom
Thiry1:fix/prefer-dom-node-dataset
Dec 15, 2025
Merged

fix(linter/unicorn/prefer-dom-node-dataset): ignore awaited getAttribute call#16882
camc314 merged 2 commits intooxc-project:mainfrom
Thiry1:fix/prefer-dom-node-dataset

Conversation

@Thiry1
Copy link
Copy Markdown
Contributor

@Thiry1 Thiry1 commented Dec 15, 2025

I've followed up on the changes in sindresorhus/eslint-plugin-unicorn#2334

@Thiry1 Thiry1 requested a review from camc314 as a code owner December 15, 2025 08:35
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 15, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #16882 will not alter performance

Comparing Thiry1:fix/prefer-dom-node-dataset (a8b2369) with main (d2f9461)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit a998ceb into oxc-project:main Dec 15, 2025
21 checks passed
@camc314 camc314 self-assigned this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants