test(oxfmt): Add oxfmt --lsp test#16866
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 15, 2025
Merged
Conversation
github-actions
bot
added
A-cli
This was referenced Dec 15, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![charliecreates[bot]](https://avatars.githubusercontent.com/in/1140780?s=60&v=4){kind=small}
There was a problem hiding this comment.
The new --lsp test is likely flaky because it closes stdin immediately and only asserts on substring matches rather than decoding a complete LSP frame and validating the JSON-RPC response. Additionally, runCli() now enforces a timeout: 1000, which is prone to CI intermittency and may cause random failures for slower startup paths. Tightening the test to read/parse a full response and making the timeout configurable would significantly improve reliability.
Summary of changes
What changed
- Added a new Vitest test
apps/oxfmt/test/lsp.test.tsthat startsoxfmtwith--lsp, sends a JSON-RPCinitializerequest over stdin, and asserts the process exits successfully and returns an LSP-ish response (e.g.,Content-Length:and"capabilities"). - Refactored
apps/oxfmt/test/utils.ts:- Introduced a shared
runCli(cwd, args)helper that returns the rawexeca()result (withreject: falseand atimeout: 1000). - Removed the custom
RunResultwrapper type and mapping. - Updated
formatSnapshot()to acceptexeca’sResulttype and normalizeexitCode/stdout/stderr(exitCode ?? -1,String(stdout),String(stderr)).
- Introduced a shared
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
leaysgur
force-pushed
the
12-15-test_oxfmt_add_oxfmt_--lsp_test
branch
from
3444300 to
1289271
Compare
leaysgur
force-pushed
the
12-15-test_oxfmt_update_oxfmt_--init_migrate_tests
branch
from
203ffa2 to
a9148bd
Compare
leaysgur
force-pushed
the
12-15-test_oxfmt_add_oxfmt_--lsp_test
branch
from
1289271 to
e8e305f
Compare
Member
Merge activity
|
Just adding test, but it requires to update test utils.
graphite-app
bot
force-pushed
the
12-15-test_oxfmt_update_oxfmt_--init_migrate_tests
branch
from
a9148bd to
3dcb523
Compare
graphite-app
bot
force-pushed
the
12-15-test_oxfmt_add_oxfmt_--lsp_test
branch
from
e8e305f to
1d9e0f4
Compare
Base automatically changed from
12-15-test_oxfmt_update_oxfmt_--init_migrate_tests
to
main
December 15, 2025 02:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding test, but it requires to update test utils.