Skip to content

feat(linter/eslint-plugin-vitest): Add no-large-snapshot as vitest compatible jest rule#16846

Merged
camc314 merged 1 commit intooxc-project:mainfrom
Afsoon:12-14-vitest-comptible-jest-rule-no-large-snapshopts
Dec 14, 2025
Merged

feat(linter/eslint-plugin-vitest): Add no-large-snapshot as vitest compatible jest rule#16846
camc314 merged 1 commit intooxc-project:mainfrom
Afsoon:12-14-vitest-comptible-jest-rule-no-large-snapshopts

Conversation

@Afsoon
Copy link
Copy Markdown
Contributor

@Afsoon Afsoon commented Dec 14, 2025

Related to #4656

Add no-large-snapshot as a vitest compatible rule

Oxlint-migrate PR: oxc-project/oxlint-migrate#281

@Afsoon Afsoon requested a review from camc314 as a code owner December 14, 2025 16:17
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 14, 2025
camc314
camc314 approved these changes Dec 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 self-assigned this Dec 14, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 14, 2025

CodSpeed Performance Report

Merging #16846 will not alter performance

Comparing Afsoon:12-14-vitest-comptible-jest-rule-no-large-snapshopts (8627fda) with main (4542e75)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on main (08bf389) during the generation of this report, so 4542e75 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 merged commit f5e752c into oxc-project:main Dec 14, 2025
21 checks passed
@Boshen Boshen mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorshea connorshea connorshea approved these changes

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Afsoon @connorshea @camc314