Skip to content

feat(linter/eslint-plugin-vitest): Add prefer-to-contain as vitest compatible jest rule#16836

Merged
camc314 merged 1 commit intooxc-project:mainfrom
Afsoon:12-14-vitest-comptible-jest-rule-prefer-to-contain
Dec 14, 2025
Merged

feat(linter/eslint-plugin-vitest): Add prefer-to-contain as vitest compatible jest rule#16836
camc314 merged 1 commit intooxc-project:mainfrom
Afsoon:12-14-vitest-comptible-jest-rule-prefer-to-contain

Conversation

@Afsoon
Copy link
Copy Markdown
Contributor

@Afsoon Afsoon commented Dec 14, 2025

Related to #4656

Add prefer-to-contain as a vitest compatible rule

Oxlint-migrate PR: oxc-project/oxlint-migrate#280

@Afsoon Afsoon requested a review from camc314 as a code owner December 14, 2025 15:27
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 14, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 14, 2025

CodSpeed Performance Report

Merging #16836 will not alter performance

Comparing Afsoon:12-14-vitest-comptible-jest-rule-prefer-to-contain (3f7983e) with main (55eb0dc)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 merged commit 652a2bf into oxc-project:main Dec 14, 2025
21 checks passed
@connorshea
Copy link
Copy Markdown
Member

lol was about to review and ask for the usual "compatible with vitest" note to the rule docs for this one :) We can do that in a follow-up PR though.

graphite-app bot pushed a commit that referenced this pull request Dec 14, 2025
…_contain rule documentation (#16838)

Corrects documentation typo in the `jest/prefer-to-contain` rule and adds vitest compatibility information.

**Changes:**
- Fixed typo in rule documentation: `TThis rule triggers` → `This rule triggers`
- Added vitest compatibility note with configuration example showing how to enable `vitest/prefer-to-contain` in `.oxlintrc.json`

The vitest compatibility note follows the same format as other vitest-compatible rules in the codebase and includes a link to the eslint-plugin-vitest documentation.

<!-- START COPILOT CODING AGENT SUFFIX -->

<!-- START COPILOT ORIGINAL PROMPT -->

<details>

<summary>Original prompt</summary>

> action this PR review comment #16836 (comment)

</details>

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for you](https://github.com/oxc-project/oxc/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants