refactor(linter/plugins): shorten NodeOrToken | Comment type#16807
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 13, 2025
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Dec 13, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 13, 2025
overlookmotel
force-pushed
the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
from
b1f2d7a to
6274182
Compare
overlookmotel
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
64333ca to
bf13eba
Compare
![charliecreates[bot]](https://avatars.githubusercontent.com/in/1140780?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found. The refactor is consistent, purely type-level, and removes redundant unions without changing runtime behavior.
Summary of changes
What changed
- Simplified several public token helper function signatures in
apps/oxlint/src-js/plugins/tokens.tsby replacing the redundant parameter typeNodeOrToken | Commentwith justNodeOrToken. - Updated affected APIs consistently across:
getTokenBefore,getTokenOrCommentBefore,getTokensBeforegetTokenAfter,getTokenOrCommentAfter,getTokensAftergetTokensBetween,getFirstTokenBetween,getFirstTokensBetween,getLastTokenBetween,getLastTokensBetween
Rationale reflected in the diff
- This aligns with the refactor context that
NodeOrTokenalready includesComment(since #16805), making| Commentredundant.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies type signatures by removing redundant | Comment unions from function parameters. Since NodeOrToken is already defined as Node | Token | Comment in types.ts, the | Comment suffix is unnecessary and can be safely removed without changing the semantic meaning of the types.
Key Changes:
- Simplified 16 function parameter type declarations from
NodeOrToken | CommenttoNodeOrToken - All changes are in
apps/oxlint/src-js/plugins/tokens.ts - No functional changes - purely a type signature refactor
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
bf13eba to
393b470
Compare
graphite-app
bot
force-pushed
the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
from
6274182 to
f567ee7
Compare
overlookmotel
changed the base branch from
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
to
graphite-base/16807
overlookmotel
force-pushed
the
graphite-base/16807
branch
from
393b470 to
f6b9e5d
Compare
overlookmotel
force-pushed
the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
from
f567ee7 to
2ddff0c
Compare
overlookmotel
changed the base branch from
graphite-base/16807
to
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
overlookmotel
changed the base branch from
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
to
graphite-base/16807
overlookmotel
force-pushed
the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
from
2ddff0c to
395c082
Compare
overlookmotel
force-pushed
the
graphite-base/16807
branch
from
f6b9e5d to
272c4c9
Compare
overlookmotel
changed the base branch from
graphite-base/16807
to
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
overlookmotel
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
272c4c9 to
e35c4a8
Compare
overlookmotel
force-pushed
the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
from
395c082 to
ae67bee
Compare
Contributor
Merge activity
|
Pure refactor. `| Comment` in `NodeOrToken | Comment` is redundant. Since #16805, `NodeOrToken` = `Node | Token | Comment` anyway. Shorten to just `NodeOrToken`.
graphite-app
bot
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
e35c4a8 to
e654c13
Compare
graphite-app
bot
force-pushed
the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
from
ae67bee to
c4fb462
Compare
Base automatically changed from
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
to
main
December 13, 2025 23:01
graphite-app
bot
deleted the
12-13-refactor_linter_plugins_shorten_nodeortoken_comment_type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
| CommentinNodeOrToken | Commentis redundant. Since #16805,NodeOrToken=Node | Token | Commentanyway. Shorten to justNodeOrToken.