feat(linter/plugins)!: do not export NodeOrToken type#16806
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 13, 2025
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Dec 13, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
changed the base branch from
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
to
graphite-base/16806
overlookmotel
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
64333ca to
bf13eba
Compare
overlookmotel
force-pushed
the
graphite-base/16806
branch
from
6821b23 to
3d24979
Compare
overlookmotel
changed the base branch from
graphite-base/16806
to
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
![charliecreates[bot]](https://avatars.githubusercontent.com/in/1140780?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found in the modified code. The change cleanly removes NodeOrToken from the public API surface as intended, without introducing additional logic or complexity.
Summary of changes
Summary
- Removed
NodeOrTokenfrom the public type exports inapps/oxlint/src-js/index.ts, aligning the package surface area with the intent thatNodeOrTokenremains an internal alias (i.e.,Node | Token | Comment).
Affected export
export type { ... } from "./plugins/types.ts"no longer includesNodeOrToken.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the NodeOrToken type from the public API exports. The type is a simple alias for Node | Token | Comment, and since all three constituent types are already exported, users can construct this union type themselves if needed.
Key Changes:
- Remove
NodeOrTokenexport fromapps/oxlint/src-js/index.ts(breaking change)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
force-pushed
the
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
branch
2 times, most recently
from
babcbb4 to
a211e0f
Compare
graphite-app
bot
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
bf13eba to
393b470
Compare
overlookmotel
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
393b470 to
f6b9e5d
Compare
overlookmotel
force-pushed
the
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
branch
from
a211e0f to
1973405
Compare
This was referenced Dec 13, 2025
overlookmotel
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
f6b9e5d to
272c4c9
Compare
overlookmotel
force-pushed
the
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
branch
2 times, most recently
from
eeff8a9 to
e2d81cd
Compare
overlookmotel
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
272c4c9 to
e35c4a8
Compare
Contributor
Merge activity
|
Unnecessary to export this type, as it's just an alias for `Node | Token | Comment`. Remove it.
graphite-app
bot
force-pushed
the
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
branch
from
e2d81cd to
f814c82
Compare
graphite-app
bot
force-pushed
the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
from
e35c4a8 to
e654c13
Compare
Base automatically changed from
12-12-fix_linter_plugins_use_typescript_parser_directly_for_getting_tokens
to
main
December 13, 2025 23:01
graphite-app
bot
deleted the
12-13-feat_linter_plugins_do_not_export_nodeortoken_type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary to export this type, as it's just an alias for
Node | Token | Comment. Remove it.