refactor(linter/plugins): simplify debug assertions#16752
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 11, 2025
Merged
refactor(linter/plugins): simplify debug assertions#16752graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-linter
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors debug assertions in apps/oxlint/src-js/plugins/lint.ts to simplify the code by removing error messages, relying on stack traces for debugging instead. The refactoring consolidates debug assertions that previously used verbose if (DEBUG) blocks into concise debugAssert() calls without error messages.
Key Changes:
- Replaced verbose
if (DEBUG) { if (...) throw new Error(...) }blocks with concisedebugAssert()calls - Moved the consolidated assertions earlier in the function (before
setupFileContextcall) - Added a new assertion to validate
optionsIdsis an array
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
graphite-app
bot
force-pushed
the
12-11-build_linter_plugins_add_conformance_build
branch
from
3c42c4b to
e401961
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
Pure refactor. Just shorten the code for some debug assertions. They don't need error messages - if any fail, we can find out what's failing from stack trace.
graphite-app
bot
force-pushed
the
12-11-refactor_linter_plugins_simplify_debug_assertions
branch
from
19c0c0d to
dbc083b
Compare
Pure refactor. Just shorten the code for some debug assertions. They don't need error messages - if any fail, we can find out what's failing from stack trace.
graphite-app
bot
force-pushed
the
12-11-build_linter_plugins_add_conformance_build
branch
from
e401961 to
5723f3d
Compare
graphite-app
bot
force-pushed
the
12-11-refactor_linter_plugins_simplify_debug_assertions
branch
from
dbc083b to
5defeed
Compare
Base automatically changed from
12-11-build_linter_plugins_add_conformance_build
to
main
December 11, 2025 14:36
graphite-app
bot
deleted the
12-11-refactor_linter_plugins_simplify_debug_assertions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Just shorten the code for some debug assertions. They don't need error messages - if any fail, we can find out what's failing from stack trace.