Skip to content

style(linter/plugins): use block for multi-line if statement#16749

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-11-style_linter_plugins_use_block_for_multi-line_if_statement
Dec 11, 2025
Merged

style(linter/plugins): use block for multi-line if statement#16749
graphite-app[bot] merged 1 commit intomainfrom
12-11-style_linter_plugins_use_block_for_multi-line_if_statement

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Dec 11, 2025 •
edited
Loading

Style nit.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 11, 2025
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Dec 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 11, 2025
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review December 11, 2025 12:50
Copilot AI review requested due to automatic review settings December 11, 2025 12:50
Copilot AI reviewed Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds braces to a multi-line if statement in the plugins context file. However, this change introduces a style inconsistency with the existing codebase patterns.

Key Changes:

  • Adds curly braces to a single if (filePath === null) throw statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 mentioned this pull request Dec 11, 2025
Merged
@camc314
Copy link
Copy Markdown
Contributor

camc314 commented Dec 11, 2025

we've got a lint rule for this 😉

I made a PR to enable it here #16753

@overlookmotel overlookmotel self-assigned this Dec 11, 2025
@overlookmotel overlookmotel mentioned this pull request Dec 11, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Dec 11, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 12-11-style_linter_plugins_use_block_for_multi-line_if_statement branch from a83f4ed to 886e938 Compare December 11, 2025 13:09
@graphite-app graphite-app bot merged commit 886e938 into main Dec 11, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 12-11-style_linter_plugins_use_block_for_multi-line_if_statement branch December 11, 2025 13:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
graphite-app bot pushed a commit that referenced this pull request Dec 11, 2025
@camc314
style(all): enable eslint/curly lint rule (#16753)
2acd66e 
built on #16749, we can use the linter to be consistent here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314