fix(linter/plugins): RuleTester sort diagnostics before comparing to errors#16741
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 11, 2025
Conversation
github-actions
bot
added
A-linter
This was referenced Dec 11, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes non-deterministic test failures in the conformance tester by ensuring diagnostics are sorted by line and column before comparison with expected errors. This matches ESLint's RuleTester behavior and eliminates ordering-dependent test failures.
Key Changes:
- Added sorting of diagnostics by line then column in
assertInvalidTestCasePassesbefore comparing to expected errors - Updated conformance snapshot showing 86 additional tests now passing across 11 rules that previously had ordering-related failures
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/package/rule_tester.ts | Added diagnostic sorting by line and column before comparison to expected errors, matching ESLint's behavior |
| apps/oxlint/conformance/snapshot.md | Updated test results showing 11 rules moved from partially passing to fully passing (86 additional tests passing) due to proper diagnostic ordering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
graphite-app
bot
force-pushed
the
12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report
branch
from
4baa91e to
71632c6
Compare
graphite-app
bot
force-pushed
the
12-11-fix_linter_plugins_ruletester_sort_diagnostics_before_comparing_to_errors
branch
from
d87c7ee to
d98462b
Compare
overlookmotel
force-pushed
the
12-11-fix_linter_plugins_ruletester_sort_diagnostics_before_comparing_to_errors
branch
from
d98462b to
a9e4221
Compare
overlookmotel
force-pushed
the
12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report
branch
from
71632c6 to
339b30a
Compare
…o errors (#16741) `RuleTester` sort diagnostics in source order before comparing to expected errors. This follows what ESLint does (and it makes sense). Conformance tests now fully passing for 11 more rules.
graphite-app
bot
force-pushed
the
12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report
branch
from
339b30a to
9a964da
Compare
graphite-app
bot
force-pushed
the
12-11-fix_linter_plugins_ruletester_sort_diagnostics_before_comparing_to_errors
branch
from
a9e4221 to
36c9097
Compare
Base automatically changed from
12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report
to
main
December 11, 2025 11:57
graphite-app
bot
deleted the
12-11-fix_linter_plugins_ruletester_sort_diagnostics_before_comparing_to_errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuleTestersort diagnostics in source order before comparing to expected errors. This follows what ESLint does (and it makes sense).Conformance tests now fully passing for 11 more rules.